Conversation
Baby steps on right direction. Increasing minimum coverage to 32.65%
ppinchuk
left a comment
ppinchuk
left a comment
There was a problem hiding this comment.
Fine for now, but I'd recommend waiting to do this until we merge a bunch of those PR's. We have a backlog of open PR's that increase coverage, and I have like 3 more locally that I am waiting on that will increase coverage.
Plus, when we move to the plugin structure, I expect this number to go way up. So not to waste too much time on this, I'd recommend waiting until a lot of that work is done before increasing this value again
|
Also I'm really glad for our locked test! It caught the pixi lock file being out of date with pyproject toml :) |
There was a problem hiding this comment.
Pull Request Overview
This PR incrementally increases the minimum code coverage threshold from 30% to 32.65% for Python unit and overall tests, representing gradual progress toward better test coverage.
- Updated
--cov-fail-underparameter from 30 to 32.65 for Python test commands - Integration tests maintain their separate threshold of 15%
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@ppinchuk , shall we abort this PR and close it? Your codecov setup is doing much better than this. |
|
@ppinchuk , I'll close this one. I completely forgot this repo was public. Your codecov solution was much better. |
Baby steps on the correct direction. Increasing minimum coverage to 32.65%