Skip to content

Fix local file loader kwargs bug #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ppinchuk merged 4 commits into from
Mar 11, 2026
Merged

Fix local file loader kwargs bug #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6bf380
Don't pull from `None`
ppinchuk Mar 11, 2026
11df255
Add HTML coroutine
ppinchuk Mar 11, 2026
4dd98e1
Rust lint
ppinchuk Mar 11, 2026
9b282eb
Linter fix
ppinchuk Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions compass/scripts/process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
UsageUpdater,
JurisdictionUpdater,
HTMLFileLoader,
read_html_file,
)
from compass.utilities import (
LLM_COST_REGISTRY,
Expand Down Expand Up @@ -519,11 +520,12 @@ def local_file_loader_kwargs(self):
"""dict: Keyword arguments for ``AsyncLocalFileLoader``"""
file_loader_kwargs = {
"pdf_read_coroutine": read_pdf_file,
"html_read_coroutine": read_html_file,
"pdf_read_kwargs": (
self.process_kwargs.file_loader_kwargs.get("pdf_read_kwargs")
self.file_loader_kwargs.get("pdf_read_kwargs")
),
Comment thread
ppinchuk marked this conversation as resolved.
"html_read_kwargs": (
self.process_kwargs.file_loader_kwargs.get("html_read_kwargs")
self.file_loader_kwargs.get("html_read_kwargs")
),
}

Expand Down
4 changes: 3 additions & 1 deletion crates/compass/src/scraper/ordinance/qualitative.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,9 @@ pub(crate) mod sample {

pub(crate) fn basic() -> String {
let mut output = String::new();
output.push_str("county,state,subdivison,jurisdiction_type,FIPS,feature,summary,year,section,source\n");
output.push_str(
"county,state,subdivison,jurisdiction_type,FIPS,feature,summary,year,section,source\n",
);
output.push_str(
"county-1,state-1,,jurisdiction_type-1,11111,feature-1,summary-1,2001,section-1,source-1\n",
);
Expand Down
Loading