Skip to content

Informing FIPS with jurisdiction name#427

Merged
ppinchuk merged 3 commits into
mainfrom
log_fips
May 21, 2026
Merged

Informing FIPS with jurisdiction name#427
ppinchuk merged 3 commits into
mainfrom
log_fips

Conversation

@castelao
Copy link
Copy Markdown
Member

Although we provide a list (CSV) of jurisdictions, when running with local files, the matching is done with FIPS. This will help to identify typos and other silly errors.

@castelao castelao self-assigned this May 20, 2026
@castelao castelao requested a review from ppinchuk as a code owner May 20, 2026 05:02
Copilot AI review requested due to automatic review settings May 20, 2026 05:02
@castelao castelao added enhancement Update to logic or general code improvements p-low Priority: low topic-python-general Issues/pull requests related to python labels May 20, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 20, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.68%. Comparing base (51f003b) to head (43df7d1).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
compass/scripts/process.py 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   55.74%   55.68%   -0.06%     
==========================================
  Files          62       62              
  Lines        5983     5985       +2     
  Branches      568      568              
==========================================
- Hits         3335     3333       -2     
- Misses       2589     2592       +3     
- Partials       59       60       +1     
Flag Coverage Δ
unittests 55.68% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves operator visibility during compass process runs by including the jurisdiction’s code (typically FIPS) alongside the human-readable jurisdiction name in the startup log message, helping catch mismatches/typos when local-file processing relies on FIPS-based matching.

Changes:

  • Expanded the “Kicking off processing…” log line to include jurisdiction.code in addition to jurisdiction.full_name.

@ppinchuk
Copy link
Copy Markdown
Collaborator

Nice, more logging is always welcome (I guess within reason :P)

castelao added 3 commits May 20, 2026 22:51
Although we provide a list (CSV) of jurisdictions, when running with
local files, the matching is done with FIPS. This will help to identify
typos and other silly errors.
@ppinchuk
Copy link
Copy Markdown
Collaborator

This is small enough that I will just merge. Thanks for this @castelao!

@ppinchuk ppinchuk merged commit eab9df2 into main May 21, 2026
21 checks passed
@ppinchuk ppinchuk deleted the log_fips branch May 21, 2026 19:43
rajeee pushed a commit that referenced this pull request May 27, 2026
* log: Informing FIPS with jurisdiction name

Although we provide a list (CSV) of jurisdictions, when running with
local files, the matching is done with FIPS. This will help to identify
typos and other silly errors.

* log: Trace level of FIPS for local documents

* style: Breaking a long line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Update to logic or general code improvements p-low Priority: low topic-python-general Issues/pull requests related to python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants