Fixing building pdev on osx-arm64#428
Conversation
castelao
force-pushed
the
fix/pdev_osx_202605
branch
from
f46bbd3 to
74541c5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
=======================================
Coverage 55.70% 55.70%
=======================================
Files 62 62
Lines 5983 5983
Branches 568 568
=======================================
Hits 3333 3333
Misses 2590 2590
Partials 60 60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
For the records, I wasn't able to setup docling-* through conda-forge for all platforms, but it seems to work for OSX only. I also wasn't able to bump the standard python in pixi to 3.13 due to a pinned legacy torch, but we can leave that for later. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Pixi environment configuration and CI Pixi tooling to ensure the pdev environment can be created on osx-arm64, avoiding local build failures related to docling-parse.
Changes:
- Add
osx-arm64-specific conda dependencies fordocling,docling-core, anddocling-parseunder thepython-defaultfeature. - Bump the Pixi version used in GitHub Actions workflows from
v0.62.2tov0.68.1.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pixi.toml |
Adds osx-arm64-scoped conda dependencies to ensure Docling components resolve without compilation failures on Apple Silicon. |
.github/workflows/publish_to_pypi.yml |
Updates CI Pixi version to v0.68.1 for the build/publish environment. |
.github/workflows/docs.yml |
Updates CI Pixi version to v0.68.1 for docs builds. |
.github/workflows/codecov.yml |
Updates CI Pixi version to v0.68.1 for coverage runs. |
.github/workflows/ci-rust.yml |
Updates CI Pixi version to v0.68.1 across Rust jobs. |
.github/workflows/ci-python.yml |
Updates CI Pixi version to v0.68.1 across Python jobs (locked/unit/integration). |
ppinchuk
left a comment
ppinchuk
left a comment
There was a problem hiding this comment.
Wow I am amazed that this worked, nice job!
* cfg: Update pixi.lock to v7 * cfg: docling-* through conda for osx-arm64 * cfg: Bump pixi-version to 0.68.1
Can't build
pdevenvironment due to failing during compilation ofdocling-parse.Since it was passing on our GA tests, it is probably associated with my local toolchain. I couldn't identify the exact issue, but was able to make the conda-forge distributions to work for OSX, so this should be enough for now.