-
Notifications
You must be signed in to change notification settings - Fork 475
Add EMS actuator for CondFD sky longwave radiation override #11478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2487d34
Add EMS actuator for CondFD sky longwave radiation override
brianlball 05466ff
Add unit test for CondFD sky LW actuator override
brianlball 6d84283
Add integration test IDFs for CondFD sky LW actuator
brianlball 26b3c1e
Add Python examples and NFP for CondFD sky LW actuator
brianlball 619ca65
Strengthen CondFD sky LW actuator unit test assertions
brianlball 6a8179f
update debugging notebook with rain_flag to explain large spike in flux
brianlball 7052057
Move NFP to design/FY2026/, add background/physics/references for non…
brianlball 9917c80
Add docs and CN unit test for CondFD sky LW actuator
brianlball 4f30e9a
add test idf file
brianlball d017d56
Fix const -> constexpr for literal-initialized locals in CondFD unit …
brianlball e9a9b4e
Apply clang-format v19 to CondFD source and unit test
brianlball 02a82b2
NFP: add perf refactor note for SkyLW actuator; untrack notebook
brianlball b9f6bd0
Merge branch 'develop' into longwaverad_act
mitchute 9a155c5
separate actuator and report variable, reset report variable to 0 whe…
mitchute 0a95799
remove test file testfiles/1ZoneCondFD_Enet_EMS.idf
brianlball 18311ae
remove testfiles/1ZoneCondFD_Enet_Test.idf
brianlball e0e25e0
reduce sky longwave rad actuator conditionals usage
mitchute 417a781
Merge branch 'develop' into longwaverad_act
mitchute File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks correct so consider this just a suggestion. There are several new conditionals added to this code below, i.e., if (enetAct.isActuated). And in those uses are the same terms, hsky and hsky * Tsky. It may be more efficient to create those terms here and use these new terms below without needing the conditionals.
And then just replace those terms below with these new variables without needing the new conditionals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I addressed this here e0e25e0. Hopefully that's the final commit on this, and then we can merge it.