Skip to content

Introduce optional ordered_json version of epJSON#11480

Closed
joseph-robertson wants to merge 4 commits intodevelopfrom
epjson-ordered
Closed

Introduce optional ordered_json version of epJSON#11480
joseph-robertson wants to merge 4 commits intodevelopfrom
epjson-ordered

Conversation

@joseph-robertson
Copy link
Copy Markdown
Collaborator

Pull request overview

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@joseph-robertson joseph-robertson self-assigned this Mar 20, 2026
@joseph-robertson joseph-robertson added the Defect Includes code to repair a defect in EnergyPlus label Mar 20, 2026
@brianlball
Copy link
Copy Markdown
Contributor

brianlball commented Mar 25, 2026

@mitchute this was objected to during the iteration. The solution should not be ordering the JSON. Sounds like there is a more fundamental issue that simulation resutlts are depending on the order of the JSON, and it shouldnt. #10924

@brianlball brianlball added the DoNotMerge Code that requires additional attention and investigation label Mar 25, 2026
@joseph-robertson
Copy link
Copy Markdown
Collaborator Author

@mitchute this was objected to during the iteration. The solution should not be ordering the JSON. Sounds like there is a more fundamental issue that simulation resutlts are depending on the order of the JSON, and it shouldnt. #10924

Looks like @rraustad is fixing #10924 in #11484. I'm assuming that if the PR solves the issue for IDFs, then it will also solve it for epJSONs.

My original thought behind this PR was just to have order consistency in output tables. See the original issue. I wasn't necessarily trying to solve any simulation differences/inconsistencies between the (ordered) IDF and (unordered) epJSON.

@joseph-robertson
Copy link
Copy Markdown
Collaborator Author

Superceded by #11523.

@joseph-robertson joseph-robertson deleted the epjson-ordered branch April 13, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus DoNotMerge Code that requires additional attention and investigation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

idf converted to epjson alphabetizes by object name

4 participants