fix #11512: evap cooler docs — constant wet-bulb, not constant enthalpy#11530
Merged
Conversation
direct evap follows constant wet-bulb by defn of Twb; doc had it inverted. code already const-Twb (EvaporativeCoolers.cc:1739, 3164). fix prose, caption, add enthalpy-balance eqn. mirror in I/O-ref.
Collaborator
|
@brianlball I made a minor touch-up here: 32c0810 let me know if that's ok. |
Contributor
Author
|
@mitchute I like it |
|
Collaborator
|
More regression testing hallucinations... merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11512. Docs-only.
The direct evaporative cooler docs claim the process follows a line of constant enthalpy and treat constant wet-bulb as a close-enough proxy. The physics is the other way around: an adiabatic evap-cooling process follows constant thermodynamic wet-bulb temperature by definition (this is the defining process for Twb), and constant-h is the approximation — the outlet enthalpy differs from inlet by the enthalpy carried in by the liquid water before it evaporates:
Code is already correct — doc was inverted
The implementation holds Twb constant and derives W, h from it:
src/EnergyPlus/EvaporativeCoolers.cc:1739—CalcDirectEvapCooler(CelDekPad):OuletWetBulbTemp = InletWetBulbTempsrc/EnergyPlus/EvaporativeCoolers.cc:3164—CalcDirectResearchSpecialEvapCooler(ResearchSpecial):OuletWetBulbTemp = TEWBBoth paths use
OutletTemp = TEDB − (TEDB − TEWB) · ε(wet-bulb-depression, not enthalpy-depression) and compute outlet enthalpy as a result viaPsyHFnTdbW. Inline comments at both sites already state "WET BULB TEMP IS CONSTANT ACROSS A DIRECT EVAPORATION COOLER". Governing equation atevaporative-coolers.tex:26(ε·(T_odb − T_owb)) is also a Twb-depression formula.Changes
doc/engineering-reference/.../evaporative-coolers.texConstant Enthalpy→Constant Wet-Bulb Temperaturedoc/input-output-reference/.../group-evaporative-coolers.texImage check
Examined
image4790.pngandimage416.png. Diagonal lines on both are already labeled Wet-Bulb Temp [F] and the A→B process line is drawn along one of them. Images were already physically correct; only the captions were wrong. No image edits needed.Label rename
fig:psychrometric-chart-constant-enthalpy→fig:psychrometric-chart-constant-wetbulb— grep confirmed no\ref{}uses the old label anywhere in the repo.Test plan