Skip to content

Fix Incorrect Fluid Prop Warnings#11543

Merged
mitchute merged 1 commit into
developfrom
11513-fluid-prop-warnings
Apr 30, 2026
Merged

Fix Incorrect Fluid Prop Warnings#11543
mitchute merged 1 commit into
developfrom
11513-fluid-prop-warnings

Conversation

@mitchute
Copy link
Copy Markdown
Collaborator

@mitchute mitchute commented Apr 24, 2026

Pull request overview

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mitchute mitchute added the Defect Includes code to repair a defect in EnergyPlus label Apr 24, 2026
dareumnam
dareumnam reviewed Apr 30, 2026
View reviewed changes
Comment thread src/EnergyPlus/FluidProperties.cc
ShowRecurringWarningErrorAtEnd(
state,
EnergyPlus::format("{}: Temperature out of range (too low) for fluid [{}] viscosity **", routineName, this->Name),
this->errors[(int)GlycolError::ViscosityLow].index,
Copy link
Copy Markdown
Collaborator

@dareumnam dareumnam Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, this line indicates it should be GlycolError::ViscosityLow

@dareumnam
Copy link
Copy Markdown
Collaborator

dareumnam commented Apr 30, 2026

Built this branch locally and confirmed that the unit tests passed. This looks good to me.

rraustad
rraustad approved these changes Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rraustad rraustad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mitchute
Copy link
Copy Markdown
Collaborator Author

mitchute commented Apr 30, 2026

Thanks @dareumnam and @rraustad. Merging.

@mitchute mitchute merged commit d59fe01 into develop Apr 30, 2026
12 checks passed
@mitchute mitchute deleted the 11513-fluid-prop-warnings branch April 30, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dareumnam dareumnam dareumnam left review comments

@rraustad rraustad rraustad approved these changes

Assignees

No one assigned

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Copy/paste error in FluidProperties.cc

4 participants

@mitchute @dareumnam @rraustad @nrel-bot-2c