Remove fmt - Part 1: Propagate `std::format` where possible and eliminate `{T}` string formatting option by mitchute · Pull Request #11553 · NatLabRockies/EnergyPlus

mitchute · 2026-04-28T21:56:24Z

Pull request overview

Begins the process of removing third-party/fmt library in lieu of std::format that is now available in C++20.

Description of the purpose of this PR

Propagates the use of std::format to all the easy places. I should have completed this in Upgrade to C++20 Standard #11423. Oh well.
Eliminates all uses of the {T} formatting option. This results in some least significant figure rounding due to differences between how the T option vs. std::format behave.

Pull Request Author

Reviewer

mitchute

Walk through

mitchute · 2026-04-28T21:57:59Z

        Real64 viscosity;

        AirState();
-        explicit AirState(double const airDensity);


Just making the definition and declaration names the same.

mitchute · 2026-04-28T21:59:16Z

 // C++ Headers
 #include <algorithm>
 #include <cmath>
+#include <format>
 #include <set>
 #include <string>

 // ObjexxFCL Headers
 #include <ObjexxFCL/Array.functions.hh>
-#include <ObjexxFCL/Array2D.hh>
-// #include <ObjexxFCL/Fmath.hh>
+
+// Local Headers
+#include "AirflowNetwork/Elements.hpp"
+#include "AirflowNetwork/Solver.hpp"

 // EnergyPlus Headers


Since was adding #include <format> in a bunch of places, I spent a little time making the header includes consistent.

mitchute · 2026-04-28T21:59:50Z

@@ -954,25 +952,25 @@ namespace AirflowNetwork {
                }
                if (MultizoneCompDetOpeningData(i).NumFac > 2) {
                    if (MultizoneCompDetOpeningData(i).OpenFac2 >= MultizoneCompDetOpeningData(i).OpenFac3) {
-                        ShowSevereError(m_state, EnergyPlus::format("{}: {} = {}", RoutineName, CurrentModuleObject, thisObjectName));
+                        ShowSevereError(m_state, std::format("{}: {} = {}", RoutineName, CurrentModuleObject, thisObjectName));


25000 of these later...

mitchute · 2026-04-28T22:03:42Z

@@ -319,7 +316,7 @@ void InitializeRootFinder(EnergyPlusData &state,
            XMinReset = XMax;
        } else {
            ShowFatalError(
-                state, EnergyPlus::format("InitializeRootFinder: Invalid min/max bounds XMin={:.6T} must be smaller than XMax={:.6T}", XMin, XMax));


Thankfully it's just a 1:1 replacement, with the noted LSF rounding. ~~IMO, that doesn't appear to be an issue.~~

Edit - this is addressed in subsequent commits.

mitchute · 2026-04-28T22:04:58Z

-    // T formatting is like R, but it trims instead of rounding
-    EXPECT_EQ(format("{:.3T}", 7.63142731775999418747E-003), "7.631E-003");
-    EXPECT_EQ(format("{:.3T}", 1.28349999999999948505E-004), "1.283E-004");
-    EXPECT_EQ(format("{:.3T}", 2.56700000000000005430E-004), "2.567E-004");
-    EXPECT_EQ(format("{:.3T}", 0.15159450340364988286), "0.151");
-    EXPECT_EQ(format("{:.3T}", 0.0), "0.000");
-
-    EXPECT_EQ(format("{:.3T}", 2.14633893312000043063E-002), "2.146E-002");
-    EXPECT_EQ(format("{:.3T}", 8.55666666666666278192E-005), "8.556E-005");
-    EXPECT_EQ(format("{:.3T}", 6.41749999999999878051E-005), "6.417E-005");
-    EXPECT_EQ(format("{:.3T}", 0.10106298657208269420), "0.101");
-
-    EXPECT_EQ(format("{:.4T}", 0.14999999999999999445), "0.1500");
-    EXPECT_EQ(format("{:.3T}", 4500.0), "4500.000");
-    EXPECT_EQ(format("{:.4T}", 7.1846416734478406596), "7.1846");
-    EXPECT_EQ(format("{:.4T}", 1.1846416734478406596), "1.1846");
-    EXPECT_EQ(format("{:.4T}", 6.2565195738294026029), "6.2565");
-    EXPECT_EQ(format("{:.4T}", 0.25651957382940215879), "0.2565");


Old unit test showing how {T} option was behaving.

shorowit · 2026-04-28T22:07:18Z

Looks like this partially addresses #11241

github-actions · 2026-04-28T22:58:09Z

⚠️ Regressions detected on macos-14 for commit `f8bb0a4`

Regression Summary

EDD: 13
EIO: 85
Table Small Diffs: 42
ERR: 37

github-actions · 2026-04-28T23:14:08Z

⚠️ Regressions detected on ubuntu-24.04 for commit `f8bb0a4`

Regression Summary

EDD: 15
EIO: 85
Table Small Diffs: 42
ERR: 37

github-actions · 2026-04-29T00:05:23Z

⚠️ Regressions detected on macos-14 for commit `d1dbd08`

Regression Summary

EDD: 13
EIO: 85
Table Small Diffs: 42
ERR: 37

github-actions · 2026-04-29T00:08:36Z

⚠️ Regressions detected on ubuntu-24.04 for commit `d1dbd08`

Regression Summary

EDD: 15
EIO: 85
Table Small Diffs: 42
ERR: 37

…001677 (m3/s)/W (125 cfm/ton) and 0.00003355 (m3/s)/W (250 cfm/ton).' changing to scientific notaton with 3 least significant digits

…. I think these are all likely to be in Celcius, so keeping a floating point representation seem appropriate

mitchute · 2026-04-29T18:43:01Z

Diff Summary

DX Coils - Rated Vol Flow Per Watt Reporting

Diff resolution commit: ab5e29c

-   **   ~~~   ** Min Rated Vol Flow Per Watt=[4.027E-005], Rated Vol Flow Per Watt=[7.475E-005], Max Rated Vol Flow Per Watt=[6.041E-005]. See Input Output Reference Manual for valid range.
+   **   ~~~   ** Min Rated Vol Flow Per Watt=[4.027e-05], Rated Vol Flow Per Watt=[7.476e-05], Max Rated Vol Flow Per Watt=[6.041e-05]. See Input-Output Reference Manual for valid range.

Per this IO Ref, these values should be between '0.00001677 (m3/s)/W (125 cfm/ton) and 0.00003355 (m3/s)/W (250 cfm/ton).' Changing to fixed sci notation to reflect this.

Psychrometric "Resultant Temperature" Messages

Diff resolution commit: fbd4a5a (ignore the files added accidentally)

-   **   ~~~   **  Resultant Temperature= -3.62E-003
+   **   ~~~   **  Resultant Temperature= -0.0036

These look like they will always be in Celsius, so a fixed floating point number should be sufficient.

EMS .edd File Trace Data

Diff resolution commit: e9eb04d

-CURVEOVERWRITEMGR,Line 8,SET C1 = 0.942567793,0.942567, During Warmup, Occurrence info=MIAMI INTL AP ANN HTG 99.6% CONDNS DB, 01/21 00:00 - 00:15
-CURVEOVERWRITEMGR,Line 9,SET C2 = 0.009543347,9.543347E-003, During Warmup, Occurrence info=MIAMI INTL AP ANN HTG 99.6% CONDNS DB, 01/21 00:00 - 00:15
-CURVEOVERWRITEMGR,Line 10,SET C2A = 0.009543347E0,9.543347E-003, During Warmup, Occurrence info=MIAMI INTL AP ANN HTG 99.6% CONDNS DB, 01/21 00:00 - 00:15
-CURVEOVERWRITEMGR,Line 11,SET C3 = 0.00068377E0,6.837700E-004, During Warmup, Occurrence info=MIAMI INTL AP ANN HTG 99.6% CONDNS DB, 01/21 00:00 - 00:15
+CURVEOVERWRITEMGR,Line 8,SET C1 = 0.942567793,0.942568, During Warmup, Occurrence info=MIAMI INTL AP ANN HTG 99.6% CONDNS DB, 01/21 00:00 - 00:15
+CURVEOVERWRITEMGR,Line 9,SET C2 = 0.009543347,9.543347e-03, During Warmup, Occurrence info=MIAMI INTL AP ANN HTG 99.6% CONDNS DB, 01/21 00:00 - 00:15
+CURVEOVERWRITEMGR,Line 10,SET C2A = 0.009543347E0,9.543347e-03, During Warmup, Occurrence info=MIAMI INTL AP ANN HTG 99.6% CONDNS DB, 01/21 00:00 - 00:15
+CURVEOVERWRITEMGR,Line 11,SET C3 = 0.00068377E0,6.837700e-04, During Warmup, Occurrence info=MIAMI INTL AP ANN HTG 99.6% CONDNS DB, 01/21 00:00 - 00:15

This is only used to print to the .edd trace, so I picked a cutoff to switch between fixed floating point and scientific notation. Let me know if that's a problem.

Psychrometric Humidity Ratio Messages

Diff resolution commit: 05e1825

-   **   ~~~   **  Input Humidity Ratio= 1.257224E-003
+   **   ~~~   **  Input Humidity Ratio= 1.257225e-03

This is another number that's always going to be less than 0, so scientific notation seems appropriate for these.

Tank and Tank Node Volumes

Diff resolution commits: 34fa25b 32811a7

-Chilled Water Tank Information,ThermalStorage:ChilledWater:Mixed,CHILLED WATER STORAGE TANK 1,50.0000,4.2120E-003,4.1819E-003
+Chilled Water Tank Information,ThermalStorage:ChilledWater:Mixed,CHILLED WATER STORAGE TANK 1,50.0000,4.2121e-03,4.1820e-03

The tank and tank node volume are in m^3, and might be big or small, so I converted these to sci notation.

Let me know if this is a problem for any of these. I think I've addressed all of the major issues. Remaining diffs are related to the LSF rounding differences between the old and new formats.

github-actions · 2026-04-29T18:53:25Z

⚠️ Regressions detected on macos-14 for commit `8407ffe`

Regression Summary

EDD: 13
EIO: 84
Table Small Diffs: 41
ERR: 37

github-actions · 2026-04-29T19:11:27Z

⚠️ Regressions detected on ubuntu-24.04 for commit `8407ffe`

Regression Summary

EDD: 15
EIO: 84
Table Small Diffs: 41
ERR: 37

github-actions · 2026-04-29T19:15:15Z

⚠️ Regressions detected on macos-14 for commit `038014b`

Regression Summary

EDD: 13
EIO: 84
Table Small Diffs: 41
ERR: 37

github-actions · 2026-04-29T19:30:05Z

⚠️ Regressions detected on ubuntu-24.04 for commit `038014b`

Regression Summary

EDD: 15
EIO: 84
Table Small Diffs: 41
ERR: 37

github-actions · 2026-04-29T19:46:13Z

⚠️ Regressions detected on macos-14 for commit `01a1653`

Regression Summary

EDD: 13
EIO: 83
Table Small Diffs: 41
ERR: 37

github-actions · 2026-04-29T19:55:20Z

⚠️ Regressions detected on ubuntu-24.04 for commit `01a1653`

Regression Summary

EDD: 15
EIO: 83
Table Small Diffs: 41
ERR: 37

rraustad

Diff review showed very small changes in magnitude and format.

mitchute added 2 commits April 28, 2026 11:55

first pass at transitioning to use std::format

1b2363b

remove 'T' formatting option, some header cleanups for consistency

25786b4

mitchute added the Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring label Apr 28, 2026

mitchute commented Apr 28, 2026

View reviewed changes

mitchute marked this pull request as draft April 28, 2026 22:06

remove unecessary cast

a6a39df

mitchute added 8 commits April 29, 2026 09:53

fix DX coil warnings. per I/O ref, the values should be between '0.00…

ab5e29c

…001677 (m3/s)/W (125 cfm/ton) and 0.00003355 (m3/s)/W (250 cfm/ton).' changing to scientific notaton with 3 least significant digits

fix psychrometric resultant temperature messages to add more sig figs…

fbd4a5a

…. I think these are all likely to be in Celcius, so keeping a floating point representation seem appropriate

make .edd trace information follow user information a little closer

e9eb04d

humidity ratio to scientific notation in psychrometric prints

05e1825

update tank node volumes to use scientific notation

34fa25b

remove ccache

2c78778

remove files added by mistake

1ceabb3

more fun with tank volume reporting

32811a7

mitchute marked this pull request as ready for review April 29, 2026 18:43

rraustad approved these changes Apr 30, 2026

View reviewed changes

Conversation

mitchute commented Apr 28, 2026

Pull request overview

Description of the purpose of this PR

Pull Request Author

Reviewer

Uh oh!

mitchute left a comment

Choose a reason for hiding this comment

Uh oh!

mitchute Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

mitchute Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

mitchute Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

mitchute Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mitchute Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

shorowit commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

⚠️ Regressions detected on macos-14 for commit f8bb0a4

Uh oh!

github-actions Bot commented Apr 28, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit f8bb0a4

Uh oh!

github-actions Bot commented Apr 29, 2026

⚠️ Regressions detected on macos-14 for commit d1dbd08

Uh oh!

github-actions Bot commented Apr 29, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit d1dbd08

Uh oh!

mitchute commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff Summary

DX Coils - Rated Vol Flow Per Watt Reporting

Psychrometric "Resultant Temperature" Messages

EMS .edd File Trace Data

Psychrometric Humidity Ratio Messages

Tank and Tank Node Volumes

Uh oh!

github-actions Bot commented Apr 29, 2026

⚠️ Regressions detected on macos-14 for commit 8407ffe

Uh oh!

github-actions Bot commented Apr 29, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit 8407ffe

Uh oh!

github-actions Bot commented Apr 29, 2026

⚠️ Regressions detected on macos-14 for commit 038014b

Uh oh!

github-actions Bot commented Apr 29, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit 038014b

Uh oh!

github-actions Bot commented Apr 29, 2026

⚠️ Regressions detected on macos-14 for commit 01a1653

Uh oh!

github-actions Bot commented Apr 29, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit 01a1653

Uh oh!

rraustad left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mitchute Apr 28, 2026 •

edited

Loading

⚠️ Regressions detected on macos-14 for commit `f8bb0a4`

⚠️ Regressions detected on ubuntu-24.04 for commit `f8bb0a4`

⚠️ Regressions detected on macos-14 for commit `d1dbd08`

⚠️ Regressions detected on ubuntu-24.04 for commit `d1dbd08`

mitchute commented Apr 29, 2026 •

edited

Loading

⚠️ Regressions detected on macos-14 for commit `8407ffe`

⚠️ Regressions detected on ubuntu-24.04 for commit `8407ffe`

⚠️ Regressions detected on macos-14 for commit `038014b`

⚠️ Regressions detected on ubuntu-24.04 for commit `038014b`

⚠️ Regressions detected on macos-14 for commit `01a1653`

⚠️ Regressions detected on ubuntu-24.04 for commit `01a1653`