Skip to content

Throw Warning and Fallback to Constant Speed Pump When Variable Speed Pump and Common Pipe are Used Together#11600

Open
mitchute wants to merge 4 commits into
developfrom
fix-var-speed-pump-w-common-pipe
Open

Throw Warning and Fallback to Constant Speed Pump When Variable Speed Pump and Common Pipe are Used Together#11600
mitchute wants to merge 4 commits into
developfrom
fix-var-speed-pump-w-common-pipe

Conversation

@mitchute
Copy link
Copy Markdown
Collaborator

@mitchute mitchute commented May 21, 2026

Pull request overview

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mitchute mitchute added the Defect Includes code to repair a defect in EnergyPlus label May 21, 2026
mitchute
mitchute commented May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator Author

@mitchute mitchute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review.

Comment thread src/EnergyPlus/HVACInterfaceManager.cc Outdated
thisCommonPipe.SupplySideInletPumpType = FlowType::Constant;
} else if (first_supply_component_type == DataPlant::PlantEquipmentType::PumpVariableSpeed) {
thisCommonPipe.SupplySideInletPumpType = FlowType::Variable;
thisCommonPipe.SupplySideInletPumpType = FlowType::Constant;
Copy link
Copy Markdown
Collaborator Author

@mitchute mitchute May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix. The warnings were already here.

Comment thread ...ngineering-reference/src/building-system-simulation-system-manager/plant-condenser-loops.tex
Comment on lines +669 to +670
\item
If the primary-side, or supply-side, inlet pump is a variable speed pump, the common pipe model does not vary the primary flow rate. EnergyPlus issues a warning and the primary side operates as if the pump were constant speed.
Copy link
Copy Markdown
Collaborator Author

@mitchute mitchute May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc updates to clarify behavior.

@rraustad rraustad mentioned this pull request May 21, 2026
Open
@rraustad
Copy link
Copy Markdown
Collaborator

rraustad commented May 21, 2026

@mitchute see discussion on #11599. I'm not sure how to proceed?

@mitchute
Copy link
Copy Markdown
Collaborator Author

mitchute commented May 28, 2026

@rraustad here are some changes I was considering while looking at this: 764f9a3 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Variable Speed Pump and Two-way Common Pipe Causes Hard Crash

3 participants

@mitchute @rraustad @nrel-bot-2c