HPWH ducting#2117
Merged
Merged
Conversation
Contributor
Author
|
Test failure is related to NatLabRockies/OpenStudio#5547. Will need an additional workaround when modeling whole SFA/MF buildings if it's not addressed. |
…rflow rate to 200 cfm, a better average value.
Contributor
Author
|
TODO:
|
…o hpwh_exhaust_ducting # Conflicts: # HPXMLtoOpenStudio/measure.xml
… hpwh_exhaust_ducting # Conflicts: # HPXMLtoOpenStudio/measure.xml # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv
jmaguire1
reviewed
Jan 6, 2026
jmaguire1
reviewed
Jan 6, 2026
jmaguire1
reviewed
Jan 6, 2026
jmaguire1
reviewed
Jan 6, 2026
jmaguire1
left a comment
jmaguire1
left a comment
Collaborator
There was a problem hiding this comment.
A few really minor comments to look at, but overall looks great and local testing was giving me reasonable results. Thanks for doing this Scott!!
… hpwh_exhaust_ducting # Conflicts: # HPXMLtoOpenStudio/measure.xml # workflow/tests/base_results/results_simulations_bills.csv # workflow/tests/base_results/results_simulations_energy.csv # workflow/tests/base_results/results_simulations_loads.csv # workflow/tests/base_results/results_simulations_misc.csv # workflow/tests/base_results/results_simulations_panel.csv
46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Allow HPWHs to have exhaust air ducted to the outside. Closes #2096.
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run