Skip to content

Fix PV grid connection fee edge case #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shorowit merged 2 commits into from
Apr 30, 2026
Merged

Fix PV grid connection fee edge case #2206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
712d41f
Initial cleanup before the bugfix.
shorowit Apr 30, 2026
61016e0
Add bugfix and tests.
shorowit Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ __Bugfixes__
- Fixes unmet hours outputs, which could be missing some periods of unmet hours.
- Fixes timeseries outputs for heating/cooling setpoints.
- Fixes logic in HP multi-stage backup advanced research feature.
- Fixes PV grid connection fee applying in utility bill calculation even if the home has no PV.

## OpenStudio-HPXML v1.11.1

Expand Down
5 changes: 4 additions & 1 deletion ReportUtilityBills/measure.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,10 @@ def get_pv_monthly_fee(bill_scenario, hpxml_buildings)
end
end
elsif not bill_scenario.pv_monthly_grid_connection_fee_dollars.nil?
pv_monthly_fee = bill_scenario.pv_monthly_grid_connection_fee_dollars
has_pv = hpxml_buildings.map { |hpxml_bldg| hpxml_bldg.pv_systems.map { |pv_system| pv_system.max_power_output }.sum }.sum > 0
if has_pv
pv_monthly_fee = bill_scenario.pv_monthly_grid_connection_fee_dollars
end
Comment on lines -327 to +330
Copy link
Copy Markdown
Contributor Author

@shorowit shorowit Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is the bugfix.

Copy link
Copy Markdown
Collaborator

@jmaguire1 jmaguire1 Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that was fast! Thanks @shorowit!

end

return pv_monthly_fee
Expand Down
8 changes: 4 additions & 4 deletions ReportUtilityBills/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
<error>Failed to infer measure name from '/mnt/c/git/openstudio-hpxml/ReportUtilityBills/measure.rb'</error>
<name>report_utility_bills</name>
<uid>ca88a425-e59a-4bc4-af51-c7e7d1e960fe</uid>
<version_id>ef1c155c-852e-4dcf-8cd4-cf2029e7c3c5</version_id>
<version_modified>2026-03-19T22:48:22Z</version_modified>
<version_id>fb1e14f6-89e9-4e7a-87a6-6e9f60ee73f0</version_id>
<version_modified>2026-04-30T21:38:53Z</version_modified>
<xml_checksum>15BF4E57</xml_checksum>
<class_name>ReportUtilityBills</class_name>
<display_name>Utility Bills Report</display_name>
Expand Down Expand Up @@ -181,7 +181,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>ED3188F5</checksum>
<checksum>06397C29</checksum>
</file>
<file>
<filename>detailed_rates/README.md</filename>
Expand Down Expand Up @@ -361,7 +361,7 @@
<filename>test_report_utility_bills.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>95CFA2CF</checksum>
<checksum>C44CE366</checksum>
</file>
</files>
</measure>
Loading