Skip to content

Update default energy rates#2207

Draft
bpark1327 wants to merge 15 commits intomasterfrom
update_energy_rates
Draft

Update default energy rates#2207
bpark1327 wants to merge 15 commits intomasterfrom
update_energy_rates

Conversation

@bpark1327
Copy link
Copy Markdown
Collaborator

Pull Request Description

Closes #2194

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.sch) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@bpark1327 bpark1327 added this to the 1.12.0 milestone Apr 30, 2026
@bpark1327 bpark1327 self-assigned this Apr 30, 2026
@bpark1327 bpark1327 added the enhancement New feature or request label Apr 30, 2026
Comment on lines +109 to +110
# Collect all matching rows for this state + fuel, keyed by year (desc)
matched_rows = []
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bpark1327 You can simplify this code a lot now that we just have a single row for each state/fuel combination, right? No longer a matched_rows array, no longer need latest/prior below, etc.

@bpark1327
Copy link
Copy Markdown
Collaborator Author

@shorowit I wanted to follow up on your comment about ensuring OS-HPXML skips utility bill calculations entirely (instead of proceeding with a zero coal rate). Looking at the test case below, it seems like that behavior might already be in place. Am I interpreting that correctly?

@shorowit
Copy link
Copy Markdown
Contributor

shorowit commented May 4, 2026

@shorowit I wanted to follow up on your comment about ensuring OS-HPXML skips utility bill calculations entirely (instead of proceeding with a zero coal rate). Looking at the test case below, it seems like that behavior might already be in place. Am I interpreting that correctly?

Yes, I agree with you. Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update default energy rates

2 participants