Fix #4219 - Fix #4628 - DesignSpecificationOutdoorAir (use a DSOA:SpaceList if appropriate insead of using first dsoa found) and ControllerMechanicalVentilation upgrades by jmarrec · Pull Request #5384 · NatLabRockies/OpenStudio

Start providing a function that will create a DSOA:SpaceList if needed

jmarrec

committed

Hide the translateDesignSpecificationOutdoorAir so there's no risk of calling it (Compiler Driven Development!)

jmarrec

committed

Don't use a DSOA:SPaceList if there's only one DSOA in Spaces case

jmarrec

committed

Start by filling up the Controller:MV extensible groups using the getOrCreateThermalZoneDSOA

jmarrec

committed

Similar simple updates to use getOrCreateThermalZoneDSOA

jmarrec

committed

The big one: make ForwardTranslateThermalZone use getOrCreateThermalZoneDSOA

jmarrec

committed

I have to put back translateDesignSpecificationOutdoorAir for AirTerminalDualDuctVAV

jmarrec

committed

minor tweak

jmarrec

committed

Clang-format

jmarrec

committed

Fixup test: we sort the spaces with a DSOA by space names like it was implicitly done before for reproducibility

jmarrec

committed

Add a failing test for Controller:MV

jmarrec

committed

This is unfortunate but without a DesignDay: ControllerMV never gets the DSOAs

jmarrec

committed

Fill up extensible groups for Zone/DSOA in ControllerMV in the right location

jmarrec

committed

Expand testing to ensure we do not have zones without a DSOA on the Controller:MV

jmarrec

committed

Try to avoid error.

Joe Robertson

authored and

jmarrec

committed

Another try.

Joe Robertson

authored and

jmarrec

committed

Use custom E+ build with two extra PRs (Missing i386 windows + centos)

jmarrec

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #4219 - Fix #4628 - DesignSpecificationOutdoorAir (use a DSOA:SpaceList if appropriate insead of using first dsoa found) and ControllerMechanicalVentilation upgrades#5384

Fix #4219 - Fix #4628 - DesignSpecificationOutdoorAir (use a DSOA:SpaceList if appropriate insead of using first dsoa found) and ControllerMechanicalVentilation upgrades#5384
jmarrec merged 17 commits into
developfrom
4219-DSOA

Commits on May 26, 2025

Start providing a function that will create a DSOA:SpaceList if needed

Hide the translateDesignSpecificationOutdoorAir so there's no risk of calling it (Compiler Driven Development!)

Don't use a DSOA:SPaceList if there's only one DSOA in Spaces case

Start by filling up the Controller:MV extensible groups using the getOrCreateThermalZoneDSOA

Similar simple updates to use getOrCreateThermalZoneDSOA

The big one: make ForwardTranslateThermalZone use getOrCreateThermalZoneDSOA

I have to put back translateDesignSpecificationOutdoorAir for AirTerminalDualDuctVAV

minor tweak

Clang-format

Fixup test: we sort the spaces with a DSOA by space names like it was implicitly done before for reproducibility

Add a failing test for Controller:MV

This is unfortunate but without a DesignDay: ControllerMV never gets the DSOAs

Fill up extensible groups for Zone/DSOA in ControllerMV in the right location

Expand testing to ensure we do not have zones without a DSOA on the Controller:MV

Try to avoid error.

Another try.

Use custom E+ build with two extra PRs (Missing i386 windows + centos)