Test 5384 - Alternative#5409
Closed
jmarrec wants to merge 16 commits into
Closed
Conversation
… calling it (Compiler Driven Development!)
…OrCreateThermalZoneDSOA
… implicitly done before for reproducibility The DSOA:List was created on a sorted vector<Space> cf https://github.com/NREL/OpenStudio/blob/d9e51bd3254b6f3d44f70868231e814ef496f52c/src/energyplus/ForwardTranslator/ForwardTranslateThermalZone.cpp#L216-L217 and https://github.com/NREL/OpenStudio/blob/d9e51bd3254b6f3d44f70868231e814ef496f52c/src/energyplus/ForwardTranslator/ForwardTranslateThermalZone.cpp#L950-L970
…the DSOAs Without a DesignDay, the translateSizingZone is never called, and in turn the Controller:MechanicalVentilation does NOT receive the DSOAs This has been the case since the first ever commit of OS SDK on github, but it is wrong IMHO.
…location
// Extensible Groups for DSOAs are no longer pushed in translateSizingZone to retain order of the file, because:
// 1) Thermal Zones are translated before AirLoopHVACs, so we guarantee proper order (unless we mess something up, like adding a new always
// translated object early on that will call it)
// 2) Doing it in translateSizingZone means that it will NOT be written if the Sizing:Zone isn't, for eg when you have no design days
// but that is a valid use case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.