Update to v25.2.0-IOFreeze by joseph-robertson · Pull Request #5475 · NatLabRockies/OpenStudio

joseph-robertson · 2025-08-21T23:21:59Z

Pull request overview

Fixes Update to EnergyPlus 25.2.0 #5472

Pull Request Author

Model API Changes / Additions
Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
Model API methods are tested (in src/model/test)
EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
All new and existing tests passes
If methods have been deprecated, update rest of code to use the new methods

Labels:

If change to an IDD file, add the label IDDChange
If breaking existing API, add the label APIChange
If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

Perform a Code Review on GitHub
Code Style, strip trailing whitespace, etc.
All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
Labeling is ok
If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
If feature, test running new feature, try creative ways to break it
CI status: all green or justified

…uationFit.

…Yes.

joseph-robertson · 2025-10-15T21:44:01Z

  //                 = {252660024.14000002, 28129.12, 428.19, 360.93, 781.28, 3322324.62, 249308000.0};
  // To reduce the deviation, I switched the PTAC/PTHP to a Fan:OnOff with a Always Off Discrete Schedule, but it still behaves slightly differently
-  SqlResults ep_2510 = {191879399.92, 27905.27, 407.55, 361.09, 776.63, 3328949.38, 188521000.0};
+  SqlResults ep_2520 = {191879399.92, 27905.27, 407.55, 361.09, 776.63, 3328949.38, 188521000.0};


I'm not sure why (expected or not), but appears sqlFile2.annualTotalCost(FuelType::FuelOil_1).get() has increased from 188521000.0 to 188521400.0. This causes a test failure.

Probably related to this? NatLabRockies/EnergyPlus#11109

Meaning it was previously 188521400.0 but was being reported as 188521000.0?

That's my guess, yes.

Whoa, now I'm really confused. We got ubuntu back online (and not just windows), and I see the test fails on different lines. Appears the annual total costs may vary by platform???

AirflowNetwork:Distribution:DuctSizing Duct:Loss:Conduction Duct:Loss:Leakage Duct:Loss:MakeupAir HeatPump:AirToWater ThermalStorage:HotWater:Stratified ThermalStorage:PCM ThermalStorage:Sizing Output:Table:ReportPeriod

…eed (#5492)

joseph-robertson · 2025-10-16T22:13:46Z

@@ -63074,7 +64416,57 @@ Output:Table:Annual,
       \minimum 0
       \maximum 10

-
+Output:Table:ReportPeriod,


Just a note that this is not introduced in E+ v25.2.0.

…, so that IddField_Properties test does not fail.

…est stable version

jmarrec · 2025-10-20T09:33:59Z

I just updated the sql test results per Ubuntu's result, will let CI report on that.

Note that looking at build/resources/energyplus/Office_With_Many_HVAC_Types/eplusout.err, we have some iterations that don't converge etc.

   *************  ** Warning ** CalcDoe2DXCoil: Coil:Cooling:DX:SingleSpeed="COIL COOLING DX SINGLE SPEED 1" - Low condenser dry-bulb temperature error continues...
   *************  **   ~~~   **   This error occurred 538 total times;
   *************  **   ~~~   **   during Warmup 0 times;
   *************  **   ~~~   **   during Sizing 0 times.
   *************  **   ~~~   **   Max=-0.025000 [C]  Min=-16.400000 [C]
   *************
   *************  ** Warning ** CalcDoe2DXCoil: Coil:Cooling:DX:SingleSpeed="COIL COOLING DX SINGLE SPEED 1" - Full load outlet temperature indicates a possibility of frost/freeze error continues. Outlet air temperature statistics follow:
   *************  **   ~~~   **   This error occurred 3265 total times;
   *************  **   ~~~   **   during Warmup 0 times;
   *************  **   ~~~   **   during Sizing 0 times.
   *************  **   ~~~   **   Max=1.997726  Min=-12.977307
   *************
   *************  ** Warning ** CalcDoe2DXCoil: Coil:Cooling:DX:SingleSpeed="PTAC 1 SPD DX CLG COIL" - Low condenser dry-bulb temperature error continues...
   *************  **   ~~~   **   This error occurred 1654 total times;
   *************  **   ~~~   **   during Warmup 0 times;
   *************  **   ~~~   **   during Sizing 0 times.
   *************  **   ~~~   **   Max=-0.025000 [C]  Min=-17.800000 [C]
   *************
   *************  ** Warning ** SimHVAC: Exceeding Maximum iterations for all HVAC loops, during RUN PERIOD 1 continues
   *************  **   ~~~   **   This error occurred 29 total times;
   *************  **   ~~~   **   during Warmup 0 times;
   *************  **   ~~~   **   during Sizing 0 times.
   *************
   *************  ** Warning ** Enthalpy out of range (PsyTsatFnHPb)
   *************  **   ~~~   **   This error occurred 5244 total times;
   *************  **   ~~~   **   during Warmup 0 times;
   *************  **   ~~~   **   during Sizing 0 times.
   *************  **   ~~~   **   Max=-42407.194043 J/kg  Min=-64004.585725 J/kg
   *************
   *************  ** Warning ** CalcDoe2DXCoil: Coil:Cooling:DX:SingleSpeed="PTHP 1 SPD DX CLG COIL" - Low condenser dry-bulb temperature error continues...
   *************  **   ~~~   **   This error occurred 5 total times;
   *************  **   ~~~   **   during Warmup 0 times;
   *************  **   ~~~   **   during Sizing 0 times.
   *************  **   ~~~   **   Max=-2.900000 [C]  Min=-4.450000 [C]
   *************
   *************  ** Warning ** Calculated Humidity Ratio invalid (PsyWFnTdbH)
   *************  **   ~~~   **   This error occurred 564 total times;
   *************  **   ~~~   **   during Warmup 0 times;
   *************  **   ~~~   **   during Sizing 0 times.
   *************  **   ~~~   **   Max=-0.000272 []  Min=-0.008218 []

V25.2.0-IOFreeze: SiteWaterMainsTemperature's new fields

V25.2.0-IOFreeze: ExternalInterface's optional Initial Value field

ci-commercialbuildings · 2025-10-20T10:24:17Z

CI Results for d4937ce:

Ubuntu 24.04:
- OpenStudio-3.10.1-alpha+d4937cea3f-Ubuntu-24.04-x86_64.deb
- OpenStudio-3.10.1-alpha+d4937cea3f-Ubuntu-24.04-x86_64.tar.gz
Ubuntu 22.04:
Darwin:
Windows:
- OpenStudio-3.10.1-alpha+d4937cea3f-Windows.exe
- OpenStudio-3.10.1-alpha+d4937cea3f-Windows.tar.gz
Code Coverage:

jmarrec · 2025-10-20T12:08:48Z

I'm happy enough with this to drop it into develop as this will make our lifes easier wiht the others PRs

jmarrec · 2025-10-22T14:01:39Z

-       \reference HeatPumpAirToWaterFuelFiredHeatingNames
-       \note Name of the fuel fired absorption heat pump system system
-       \reference-class-name validPlantEquipmentTypes
-       \reference validPlantEquipmentNames


That deletion was wrong. Causes OS-resources "heatpump_airtowater_fuelfired" to fail now

Fixed in bde9b4f

jmarrec · 2025-10-22T14:02:53Z

-       \reference-class-name validPlantEquipmentTypes
-       \reference validPlantEquipmentNames


#5475 (review)

Start to update proposed idd.

f6ea4a1

joseph-robertson added this to the OpenStudio SDK 3.11.0 milestone Aug 21, 2025

joseph-robertson added Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels Aug 21, 2025

Joe Robertson added 26 commits August 25, 2025 09:46

Merge branch 'develop' into v25.2.0-IOFreeze

aa1bb00

Update ft field name for CoilHeatingWaterToAirHeatPumpVariableSpeedEq…

29ebfd8

…uationFit.

Add idd fields for SiteWaterMainsTemperature.

7d58536

Update model files for SiteWaterMainsTemperature.

f00b904

Update ft files for SiteWaterMainsTemperature.

db0e608

Update vt files for SiteWaterMainsTemperature.

8d88b89

Formatting.

cd92d4c

Field name changes for CoilWaterHeatingAirToWaterHeatPumpVariableSpeed.

d12f68a

Merge branch 'v25.2.0-IOFreeze' into v25.2.0-IOFreeze-mains

4d432fd

Fix new method types.

4842230

Update field name in ft test file.

1275d7c

Merge branch 'v25.2.0-IOFreeze' into v25.2.0-IOFreeze-mains

639ee0e

Return the right type.

73ee659

Update more field names in ft test file.

558e22a

Merge branch 'v25.2.0-IOFreeze' into v25.2.0-IOFreeze-mains

851d091

Minor typo in new vt test.

3375775

Actually run the new vt rule.

eabfe1c

Remove required-field for Initial Value field.

9c1e1af

Change initialValue to return optional double.

60bd88d

Update expected values for a buried site water mains ft test.

8e5857b

Update values method after change to optional getter.

746564f

Update model tests for Actuator and Schedule.

de0ed18

HeatExchangerDesiccantBalancedFlow now defaults EconomizerLockout to …

13b78a7

…Yes.

More proposed idd updates.

16f8a5e

Update idds and model test for boiler capacity greater than zero.

fa0b0a9

Update node type in idd for CentralHeatPumpSystem.

26a3222

Joe Robertson added 7 commits October 10, 2025 10:20

Merge branch 'v25.2.0-IOFreeze' into v25.2.0-IOFreeze-extint

fe4535d

Update the release notes.

e4d1e32

Update idd with Availability Schedule Name for several coil objects.

053a839

Update cmakelists with iofreeze shas.

5cfd33a

Stub GHE:Vertical:Sizing:Rectangle in proposed idd.

dcf1684

Remove reference on SizingPeriod:WeatherFileDays until object wrapped.

2e1a9be

New sql test file with iofreeze installer.

fb28a81

joseph-robertson commented Oct 15, 2025

View reviewed changes

jmarrec and others added 5 commits October 16, 2025 12:48

Add centos / AlmaLinux / win 32 hashes

baed61a

Formatting changes to made diff easier with E+

c7ac26f

Add missing objects

9d99a16

AirflowNetwork:Distribution:DuctSizing Duct:Loss:Conduction Duct:Loss:Leakage Duct:Loss:MakeupAir HeatPump:AirToWater ThermalStorage:HotWater:Stratified ThermalStorage:PCM ThermalStorage:Sizing Output:Table:ReportPeriod

Add field changes except AirLoopHVAC:UnitaryHeatPump:AirToAir:MultiSp…

133c329

…eed (#5492)

Update Jenkins library reference to fix-bug version

6455312

joseph-robertson commented Oct 16, 2025

View reviewed changes

Joe Robertson added 2 commits October 16, 2025 15:16

Remove reference on SizingPeriod:WeatherFileDays until object wrapped…

aa51961

…, so that IddField_Properties test does not fail.

Update expected fuel oil annual total cost for sqlFile2.

ba3deae

joseph-robertson marked this pull request as ready for review October 16, 2025 22:33

anchapin and others added 2 commits October 16, 2025 19:49

Remove specific version reference from Jenkins library to use the lat…

6424d08

…est stable version

Update sqlfile costs per Ubuntu's result

d40b2a2

jmarrec added 3 commits October 20, 2025 11:42

Update src/osversion/VersionTranslator.cpp

b67421b

Merge pull request #5477 from NREL/v25.2.0-IOFreeze-mains

1b5c1e4

V25.2.0-IOFreeze: SiteWaterMainsTemperature's new fields

Merge pull request #5481 from NREL/v25.2.0-IOFreeze-extint

d4937ce

V25.2.0-IOFreeze: ExternalInterface's optional Initial Value field

jmarrec merged commit e68bea3 into develop Oct 20, 2025
1 of 6 checks passed

jmarrec deleted the v25.2.0-IOFreeze branch October 20, 2025 12:08

jmarrec reviewed Oct 22, 2025

View reviewed changes

jmarrec added a commit that referenced this pull request Oct 22, 2025

Hotfix #5475 - heatpump_airtowater_fuelfired

bde9b4f

#5475 (review)

anchapin pushed a commit that referenced this pull request Nov 30, 2025

Hotfix #5475 - heatpump_airtowater_fuelfired

c3365a6

#5475 (review)

		\reference-class-name validPlantEquipmentTypes
		\reference validPlantEquipmentNames

Conversation

joseph-robertson commented Aug 21, 2025

Pull request overview

Pull Request Author

Review Checklist

Uh oh!

joseph-robertson Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmarrec commented Oct 20, 2025

Uh oh!

ci-commercialbuildings commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmarrec commented Oct 20, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

joseph-robertson Oct 15, 2025 •

edited

Loading

ci-commercialbuildings commented Oct 20, 2025 •

edited

Loading