Assign HPWH air inlet/outlet node names by joseph-robertson · Pull Request #5549 · NatLabRockies/OpenStudio

joseph-robertson · 2025-12-09T19:55:47Z

Pull request overview

Fixes Can't assign HPWH air inlet/outlet node names #5547
Adds a new FT test file WaterHeaterHeatPumpWrappedCondenser_GTest.cpp

Pull Request Author

Model API Changes / Additions
Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
Model API methods are tested (in src/model/test)
EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
All new and existing tests passes
If methods have been deprecated, update rest of code to use the new methods

Labels:

If change to an IDD file, add the label IDDChange
If breaking existing API, add the label APIChange
If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

Perform a Code Review on GitHub
Code Style, strip trailing whitespace, etc.
All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
Labeling is ok
If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
If feature, test running new feature, try creative ways to break it
CI status: all green or justified

joseph-robertson · 2025-12-09T19:58:14Z

          auto inletNode = modelObject.inletNode();
          OS_ASSERT(inletNode);
-          airInletNodeName = inletNode->name().get();
+          airInletNodeName = modelObject.airInletNodeName().value_or(inletNode->name().get());


Should the optional air node names only be translated when inletAirConfiguration is "Schedule"? Or should we have rules for when air node names can be set based on current choice of inletAirConfiguration?

github-actions · 2025-12-09T19:59:36Z

🧪 Test Results Dashboard

Summary

Metric	Value
Total Tests	4164
Passed	4145
Failed	19
Errors	0
Skipped	0
Success Rate	99.5%
Generated	2025-12-10 15:58:29 UTC

⚠️ Minor Issues Detected

🔍 Failed Tests (19 failures)

Linux-c++ (19 failures)

EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser1.EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser1 (run1)

Error Message:

SEGFAULT

Full Details:

No details available

EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser2.EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser2 (run1)

Error Message:

SEGFAULT

Full Details:

No details available

EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser3.EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser3 (run1)

Error Message:

Failed

Full Details:

No details available

OpenStudioCLI.Classic.test_measure_manager.OpenStudioCLI.Classic.test_measure_manager (run1)

Error Message:

Failed

Full Details:

No details available

CLITest-test_bundle-bundle.CLITest-test_bundle-bundle (run1)

Error Message:

Failed

Full Details:

No details available

CLITest-test_bundle-bundle_git.CLITest-test_bundle-bundle_git (run1)

Error Message:

Failed

Full Details:

No details available

CLITest-test_bundle-bundle_native_embedded.CLITest-test_bundle-bundle_native_embedded (run1)

Error Message:

Failed

Full Details:

No details available

EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser1.EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser1 (run3)

Error Message:

SEGFAULT

Full Details:

No details available

EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser2.EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser2 (run3)

Error Message:

SEGFAULT

Full Details:

No details available

EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser3.EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser3 (run3)

Error Message:

Failed

Full Details:

No details available

CLITest-test_bundle-bundle.CLITest-test_bundle-bundle (run3)

Error Message:

Failed

Full Details:

No details available

CLITest-test_bundle-bundle_git.CLITest-test_bundle-bundle_git (run3)

Error Message:

Failed

Full Details:

No details available

CLITest-test_bundle-bundle_native_embedded.CLITest-test_bundle-bundle_native_embedded (run3)

Error Message:

Failed

Full Details:

No details available

EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser1.EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser1 (run2)

Error Message:

SEGFAULT

Full Details:

No details available

EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser2.EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser2 (run2)

Error Message:

SEGFAULT

Full Details:

No details available

EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser3.EnergyPlusFixture.ForwardTranslator_WaterHeaterHeatPumpWrappedCondenser3 (run2)

Error Message:

Failed

Full Details:

No details available

CLITest-test_bundle-bundle.CLITest-test_bundle-bundle (run2)

Error Message:

Failed

Full Details:

No details available

CLITest-test_bundle-bundle_git.CLITest-test_bundle-bundle_git (run2)

Error Message:

Failed

Full Details:

No details available

CLITest-test_bundle-bundle_native_embedded.CLITest-test_bundle-bundle_native_embedded (run2)

Error Message:

Failed

Full Details:

No details available

📊 Test Run Information

Run	XML File	Status
run1	`results.xml`	✅ Found
run3	`results.xml`	✅ Found
run2	`results.xml`	✅ Found

joseph-robertson · 2025-12-09T23:29:12Z

  A6 , \field Air Inlet Node Name
       \type object-list
       \object-list ConnectionNames
+       \type alpha


Is it possible for these Node Name fields to support either a connection or string? Is that even what we'd want? Or can we get away with just string, along with updates to the forward translator (e.g., modelObject.inletNode() no longer exists).

Or maybe we want to be able to set a Node (i.e., use \object-list Node)?

ci-commercialbuildings · 2025-12-10T21:08:23Z

CI Results for 18b9044:

Ubuntu 24.04:
Ubuntu 22.04:
Darwin:
Windows:
- OpenStudio-3.11.0-rc1+18b9044df0-Windows.exe
- OpenStudio-3.11.0-rc1+18b9044df0-Windows.tar.gz
Code Coverage:

joseph-robertson · 2025-12-10T23:02:32Z

I'm not clear what the path forward should be. Should we:

(A) change air inlet/outlet node name fields to \type alpha in the idd
(B) implement setters/getters for air inlet/outlet node names
(C) replace use of modelObject.inletNode() and modelObject.outletNode() in FT file (because of (A))
(D) construct air inlet/outlet node name strings and implement getters inletNodeName and outletNodeName (includes logic from FT file around fan placement and inlet air configuration)
(E) construct node name strings and getters for other fields (e.g., outdoor/exhaust air, fan/coil inlet/oulet, etc)

I feel like maybe (D) is what we want? Or some combination of these?

@jmarrec

jmarrec · 2025-12-11T11:28:27Z

I'm not clear what the path forward should be. Should we:

* (A) change air inlet/outlet node name fields to `\type alpha` in the idd

* (B) implement setters/getters for air inlet/outlet node names

* (C) replace use of `modelObject.inletNode()` and `modelObject.outletNode()` in FT file (because of (A))

* (D) construct air inlet/outlet node name strings and implement getters `inletNodeName` and `outletNodeName` (includes logic from FT file around fan placement and inlet air configuration)

* (E) construct node name strings and getters for other fields (e.g., outdoor/exhaust air, fan/coil inlet/oulet, etc)

I feel like maybe (D) is what we want? Or some combination of these?

@jmarrec

I felt like it was easier to show than trying to explain. Please see #5551 for a prototype. I didn't even try to build it, but it should serve as a nice starter. If you and @shorowit can agree on the idea, then you can wrap up the PR by porting some of the tests you added in this PR.

And Yes, that would be (D) in your list

joseph-robertson · 2025-12-15T19:15:26Z

Superseded by #5551

Joe Robertson added 5 commits December 9, 2025 12:53

Update wrapped condenser air node names to alpha.

7d221ce

Update model files with air node name methods.

03153f5

Update wrapped condenser ft file.

0aa8a06

Add model tests for new air node name methods.

7090b05

Add new ft file for wrapped condenser.

23bfe6b

joseph-robertson self-assigned this Dec 9, 2025

joseph-robertson added Enhancement Request component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Dec 9, 2025

joseph-robertson commented Dec 9, 2025

View reviewed changes

Joe Robertson added 7 commits December 9, 2025 13:17

Fix typos in new ft test file.

d68849b

Check more fields in new ft test file.

bf53971

Include the right path to model files.

3230b75

More typos in new ft file.

0b9dc32

Missed a getDouble in new ft test file.

f223732

Try updating idd to support both connectionnames and alpha.

9c7fef8

Update ft test with more scenarios.

a7801a6

joseph-robertson commented Dec 9, 2025

View reviewed changes

Joe Robertson added 4 commits December 9, 2025 16:34

Include Node in ft test file.

c407e6a

Try setting string in connection field.

b163ec9

Separate out the test scenarios.

6239eb0

Try hardcoded inletNode and outletNode names.

18b9044

joseph-robertson closed this Dec 15, 2025

joseph-robertson deleted the hpwh-air-node-names branch December 15, 2025 19:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Assign HPWH air inlet/outlet node names#5549

Assign HPWH air inlet/outlet node names#5549
joseph-robertson wants to merge 16 commits into
developfrom
hpwh-air-node-names

joseph-robertson commented Dec 9, 2025 •

edited

Loading

Uh oh!

joseph-robertson Dec 9, 2025

Uh oh!

github-actions Bot commented Dec 9, 2025 •

edited

Loading

Uh oh!

joseph-robertson Dec 9, 2025

Uh oh!

joseph-robertson Dec 10, 2025

Uh oh!

ci-commercialbuildings commented Dec 10, 2025 •

edited

Loading

Uh oh!

joseph-robertson commented Dec 10, 2025

Uh oh!

jmarrec commented Dec 11, 2025 •

edited

Loading

Uh oh!

joseph-robertson commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

joseph-robertson commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request overview

Pull Request Author

Review Checklist

Uh oh!

joseph-robertson Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 Test Results Dashboard

Summary

⚠️ Minor Issues Detected

🔍 Failed Tests (19 failures)

Linux-c++ (19 failures)

📊 Test Run Information

Uh oh!

joseph-robertson Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

joseph-robertson Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

ci-commercialbuildings commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joseph-robertson commented Dec 10, 2025

Uh oh!

jmarrec commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joseph-robertson commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joseph-robertson commented Dec 9, 2025 •

edited

Loading

github-actions Bot commented Dec 9, 2025 •

edited

Loading

ci-commercialbuildings commented Dec 10, 2025 •

edited

Loading

jmarrec commented Dec 11, 2025 •

edited

Loading