Skip to content

FT ScheduleDay to Schedule:Day:Hourly when possible; collapse Schedule:Day:Interval#5612

Closed
shorowit wants to merge 5 commits intodevelopfrom
ft_schedule_day
Closed

FT ScheduleDay to Schedule:Day:Hourly when possible; collapse Schedule:Day:Interval#5612
shorowit wants to merge 5 commits intodevelopfrom
ft_schedule_day

Conversation

@shorowit
Copy link
Copy Markdown
Contributor

@shorowit shorowit commented Apr 23, 2026

Pull request overview

Forward translate ScheduleDay to the simpler Schedule:Day:Hourly (instead of Schedule:Day:Interval) when the object has 24 hourly values.

This can result in significantly smaller IDF files for models that define schedules using 24 hourly values for days. For example, the IDF file produced by running this HPXML file would be reduced by ~750 lines.

Example of before (left) vs after (right):
image

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

…Schedule:Day:Interval) when the object has 24 hourly values.
@shorowit shorowit self-assigned this Apr 23, 2026
@shorowit shorowit added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Apr 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

🧪 Test Results Dashboard

Summary

Metric Value
Total Tests 4144
Passed 4143
Failed 1
Errors 0
Skipped 0
Success Rate 100.0%
Generated 2026-04-24 14:24:42 UTC

⚠️ Minor Issues Detected

🔍 Failed Tests (1 failures)

Linux-c++ (1 failures)

OpenStudioCLI.Classic.test_measure_manager.OpenStudioCLI.Classic.test_measure_manager (run1)

Error Message:

Failed

Full Details:

No details available

📊 Test Run Information

Run XML File Status
run1 results.xml ✅ Found
run3 results.xml ✅ Found
run2 results.xml ✅ Found

@shorowit shorowit changed the title FT ScheduleDay to Schedule:Day:Hourly when possible FT ScheduleDay to Schedule:Day:Hourly when possible; collapse Schedule:Day:Interval Apr 24, 2026
@shorowit shorowit closed this Apr 27, 2026
@shorowit shorowit deleted the ft_schedule_day branch April 27, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant