Skip to content

Os 4.0 dev ScheduleInterval#5617

Draft
joseph-robertson wants to merge 2 commits intoos-4.0-devfrom
os-4.0-dev-schinterval
Draft

Os 4.0 dev ScheduleInterval#5617
joseph-robertson wants to merge 2 commits intoos-4.0-devfrom
os-4.0-dev-schinterval

Conversation

@joseph-robertson
Copy link
Copy Markdown
Collaborator

@joseph-robertson joseph-robertson commented Apr 29, 2026

Pull request overview

  • Start building a switch in ScheduleCompact RT for translating to:
    • ScheduleFixedInterval
    • ScheduleVariableInterval
    • ScheduleCompact
  • Switches include (A) whether (fixed) interval length exists, and (B) presence of "For: AllDays" in extensible group lines.
  • Start to write roundtrip tests for ScheduleCompact -> ScheduleCompact/ScheduleFixedInterval/ScheduleVariableInterval -> ScheduleCompact

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant