Skip to content

feat: add new types of loads for reeds to plexos translations#256

Open
mcllerena wants to merge 11 commits into
mainfrom
ml/add-new-load
Open

feat: add new types of loads for reeds to plexos translations#256
mcllerena wants to merge 11 commits into
mainfrom
ml/add-new-load

Conversation

@mcllerena
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 6, 2026 23:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds support for translating new ReEDS demand component types (electrolyzer + data center) into PLEXOS Purchasers, including purchaser/node memberships and time series transfer.

Changes:

  • Add rules mapping ReEDSElectrolyzerDemand and ReEDSDataCenterDemand to PLEXOSPurchaser and add purchaser→node membership creation.
  • Add purchaser time series transfer step to the ReEDS→PLEXOS translation flow.
  • Update tests to cover rule presence and translation behavior for the new demand types.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
pyproject.toml Adds new dependencies and switches several uv sources to editable path-based deps.
packages/r2x-reeds-to-plexos/tests/test_translation_rule_application.py Adds end-to-end translation assertions for electrolyzer/data-center demands.
packages/r2x-reeds-to-plexos/tests/test_rule_loading.py Adds tests ensuring new mapping rules exist in rules.json.
packages/r2x-reeds-to-plexos/tests/test_getters_utils.py Adds unit test for attaching time series to purchasers.
packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/translation.py Runs purchaser time-series attachment during translation.
packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/getters_utils.py Implements attach_time_series_to_purchasers.
packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/getters.py Expands lookup to include new demand components for memberships.
packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/config/rules.json Adds new purchaser rules + purchaser node membership; adjusts consuming-tech rule filtering.
packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/config/defaults.json Adds an electrolyzer defaults block.
packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/init.py Exports attach_time_series_to_purchasers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/r2x-reeds-to-plexos/tests/test_getters_utils.py Outdated
Comment thread pyproject.toml
Comment thread pyproject.toml Outdated
Comment thread packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/getters.py Outdated
Comment thread packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/getters.py Outdated
Comment thread packages/r2x-reeds-to-plexos/src/r2x_reeds_to_plexos/getters_utils.py Outdated
@github-actions github-actions Bot removed the r2x label May 7, 2026
@mcllerena mcllerena requested a review from pesap May 21, 2026 04:23
@github-actions github-actions Bot added Docs Improvements or additions to documentation r2x labels May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Docs Improvements or additions to documentation r2x_reeds_to_plexos r2x tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants