-
Notifications
You must be signed in to change notification settings - Fork 47
Allow BESS to Export #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
adfarth
wants to merge
60
commits into
develop
Choose a base branch
from
bess-export
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Allow BESS to Export #471
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
a6c74d0
initial commit
bb9cbfb
Merge branch 'develop' into bess-export
3cebd7e
start adding inputs
1575a9b
Merge branch 'develop' into bess-export
adfarth b211b44
rm can_grid_charge
adfarth e065d2f
set up framework
adfarth a8b2dca
Merge branch 'develop' into bess-export
adfarth 52f036b
update electric_utility_constraints
adfarth 47bfc79
make discharge from storage total discharge
adfarth 8d9be52
update results
adfarth b897e47
fix reopt_inputs
adfarth 946f8a0
Merge branch 'develop' into bess-export
adfarth 5ac4c84
fix indexing
adfarth a302d7f
Update inputs.jl
adfarth ae2f872
add todo
hdunham f823ae4
Update CHANGELOG.md
hdunham 9322adf
condense 4 constraints into 1
hdunham 1e0b211
Update storage_constraints.jl
hdunham 7743683
rm commented out refs to can_export_to_grid
hdunham 48c270d
rm resolved TODOs on defining dvStorageToGrid
hdunham 041d759
rmv extra constraint
adfarth cd67b3f
updt CUR to EXC
adfarth 42a4937
rmv todos and infos
adfarth 827647a
add todos, rm unneeded if
hdunham 547d1bd
MPC storage export
hdunham daf8d1d
Merge branch 'bess-export' of https://github.com/NREL/REopt.jl into b…
hdunham 7da2839
replace NEM_techs & WHL_techs w techs_by_exportbin elem, same for sto…
hdunham e19efe6
remove infos
hdunham 61aba35
Revert "replace NEM_techs & WHL_techs w techs_by_exportbin elem, same…
hdunham 1d05bec
rm todo
hdunham 335acee
reformat RE sums/comments for clarity
hdunham 056106f
fix MPC convert error
hdunham fae0ff8
combine 2 tests
hdunham 5c31eeb
correct constraint (4d) loop
hdunham f45fe81
Update runtests.jl
hdunham 55ce586
start bess export testing
hdunham 0a7c831
update bess export testing
hdunham d522d0f
add comment to clarify bound
hdunham dbb5b17
update bess export testing
hdunham cbecb6b
ex update
adfarth 1b5e9eb
export in emissions
adfarth 63a214b
Update emissions_constraints.jl
adfarth 0026738
bigM_hourly_load_plus_battery
adfarth 875cbd2
Update electric_storage.jl
adfarth e689e0f
try multi_node
adfarth adc7828
Merge branch 'develop' into bess-export
adfarth 6336466
t to b
adfarth ee1a4f1
Update electric_storage.jl
adfarth 3adec5b
Merge branch 'fixed-bess-soc' into bess-export
adfarth e1a504d
updt soc_init and add tol input
adfarth dfe1ed0
output name
adfarth 809f079
initial add of grid cost
adfarth e8793c7
updt documentation
adfarth 027fb3a
Update utils.jl
adfarth 8c996cd
Merge branch 'develop' into bess-export
adfarth f5f5d21
Merge branch 'develop' into bess-export
adfarth 07e8a3f
Merge branch 'develop' into bess-export
lixiangk1 d89dda1
Merge branch 'develop' into bess-export
adfarth a974c66
rm grid cost
adfarth 5557084
rm grid cost
adfarth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't really about what you added, but isn't NEM_techs just equal to techs_by_exportbins[:NEM]? Same with WHL_techs, NEM_storage, WHL_storage. Do you agree? If so idk why we are recreating it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I just double checked and I agree. We could probably replace all instances of NEM_techs and WHL_techs with their techs_by_export bin equivalent
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hdunham it looks like you made this change and then reverted it. I'm assuming it broke some things and if so can I resolve this convo?