update Big-M calculation on demand and energy tiers with large storage max sizes#547
Open
zolanaj wants to merge 7 commits into
Open
update Big-M calculation on demand and energy tiers with large storage max sizes#547zolanaj wants to merge 7 commits into
zolanaj wants to merge 7 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where demand and energy charges are incorrectly calculated when large storage system sizes are present. The fix updates the Big-M calculation logic to prevent artificially inflated values that occur when storage capacity significantly exceeds actual load requirements.
Key changes:
- Modified Big-M calculation to cap added storage power/energy at load-based Big-M values
- Added guard against array underflow in logging path handling
- Added test scenario with large storage sizes to validate the fix
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
test/scenarios/tiered_energy_demand.json |
Adds test case with extremely large storage capacity (10^10 kW/kWh) to validate fix |
src/logging.jl |
Adds safety check for path splitting to prevent array underflow |
src/constraints/electric_utility_constraints.jl |
Updates Big-M calculations to cap storage contribution at load-based values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixed a bug in demand and energy charge calculations for large max storage system sizes.
Contributor
Co-authored-by: zolanaj <12503579+zolanaj@users.noreply.github.com>
Fix spacing in min() function call for Julia style consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed