Add electric storage size class by rathod-b · Pull Request #564 · NatLabRockies/REopt.jl

rathod-b · 2025-12-30T22:10:13Z

No description provided.

Only adds size class in inputs processing, other code modifications pending.

Bill-Becker

Great progress. I left some comments and requests. Can you also check the results and proforma calcs to see if we need to update anything there? Please also add a test to validate that the size_class -> cost params are being properly assigned. Let's also work toward updating battery costs to the new ATB values (zero for constant, 4% O&M, scale 2025 values from 2023 dollars to 2025 dollars using CPI - I can show you what we did last year).

Bill-Becker · 2025-12-31T14:33:49Z

 end
+
+"""
+    get_pv_cost_params(; installed_cost_per_kw, size_class, tech_sizes_for_cost_curve, 


update docstring for storage instead of pv

This still has "pv" and related argument names in it.

Bill-Becker · 2025-12-31T14:35:02Z

+    min_kw::Real = 0.0,
+    max_kw::Real = 1.0e9,
+    electric_load_annual_peak::Real = 0.0,
+    electric_load_average_peak::Real = 0.0


remove "_peak" assuming this is just the average load

Bill-Becker · 2025-12-31T14:37:00Z

+    {
+      "size_class": 1,
+      "name": "Residential",
+      "kw_tech_sizes_for_cost_curve": [0, 40],


let's come up with a better name since we don't consider storage a "tech", and we're not doing a cost curve with this array for storage. How about "size_class_bounds"?

Bill-Becker · 2025-12-31T14:39:34Z

+        defaults[matching_default]
+    end
+
+    # STEP 2: Handle installed costs


We should be able to remove/avoid all this validation and separate handling for scalar versus array cost parameters, since we're not allowing an array for storage.

Yup, I corrected those instances already.

Bill-Becker · 2025-12-31T14:44:34Z


+        @info s.installed_cost_per_kw, s.size_class, s.electric_load_annual_peak, s.electric_load_average_peak
+
+        installed_cost_per_kw, installed_cost_per_kwh, installed_cost_constant, size_class,


The O&M cost % is included in the defaults .json, implying that it changes by size_class, but we're not assigning it by size_class here. I'm fine to take it out of that file and just used a fixed default of 2.5% (will become 4% from the new ATB). ATB uses the same % for all three of their size_classes

Makes sense, since the degradation wear and tear will vary by cycling and not size class.

The (new) 2025 ATB has 4% as the O&M as a fraction of total installed cost, so we should update that as well (does not change with size class) from the current 2.5%. I will comment on the actual variable to change.

@rathod-b Here's the link to the input (default value and in docstring) to be changed to 0.04, from 0.025:

REopt.jl/src/core/energy_storage/electric_storage.jl

Line 189 in e865b57

om_cost_fraction_of_installed_cost::Float64 = 0.025 # Annual O&M cost as a fraction of installed cost

Bill-Becker · 2025-12-31T14:45:50Z

+        storage_dict["off_grid_flag"] = settings.off_grid_flag
+
+        electric_load_annual_peak = maximum(electric_load.loads_kw)
+        electric_load_average_peak = sum(electric_load.loads_kw) / Int(8760*settings.time_steps_per_hour)


Why do we need to make sure it's converting to Int here?

No reason for it, updated.

bug fix for existing tests

Update costs and descriptions

fix broken test

Bugfix and update to latest costs used

Bill-Becker · 2026-02-23T15:47:43Z

+    {
+      "size_class": 1,
+      "name": "Residential",
+      "size_class_kw_bounds": [0, 40],


Small nitpick, but I'd prefer to keep the units at the end, so size_class_bounds_kw.

Update default costs to use 2025 costs converted to 2025$ instead of 2026 costs converted to 2025$. Also change size class names per feedback.

Bill-Becker

Need to update OM to 4% from 2.5% per the new ATB - we'll also have to update this in the API.

Bill-Becker · 2026-04-20T17:51:05Z

+end
+
+# TODO combine functions to load size class defaults for eligible techs.
+# Load PV default size class data from JSON file


Comment on line 565 references "PV"

Bill-Becker · 2026-05-01T13:15:01Z


+        @info s.installed_cost_per_kw, s.size_class, s.electric_load_annual_peak, s.electric_load_average_peak
+
+        installed_cost_per_kw, installed_cost_per_kwh, installed_cost_constant, size_class,


The (new) 2025 ATB has 4% as the O&M as a fraction of total installed cost, so we should update that as well (does not change with size class) from the current 2.5%. I will comment on the actual variable to change.

Bill-Becker · 2026-05-01T13:17:10Z


+        @info s.installed_cost_per_kw, s.size_class, s.electric_load_annual_peak, s.electric_load_average_peak
+
+        installed_cost_per_kw, installed_cost_per_kwh, installed_cost_constant, size_class,


@rathod-b Here's the link to the input (default value and in docstring) to be changed to 0.04, from 0.025:

REopt.jl/src/core/energy_storage/electric_storage.jl

Line 189 in e865b57

om_cost_fraction_of_installed_cost::Float64 = 0.025 # Annual O&M cost as a fraction of installed cost

Bill-Becker · 2026-05-01T13:37:49Z

@rathod-b I just merged develop into this branch and resolved the conflicts (not much), but I'll let you make the BESS O&M default cost update. There's one test that is explicitly checking for the 0.025, so we either need to hard-code that input or change the expected fraction to 0.04 in the test.

Bill-Becker · 2026-05-01T15:17:55Z

@rathod-b I just merged develop into this branch and resolved the conflicts (not much), but I'll let you make the BESS O&M default cost update. There's one test that is explicitly checking for the 0.025, so we either need to hard-code that input or change the expected fraction to 0.04 in the test.

Looks like merging develop broke the battery size class tests, and a couple others. let me know if you need any help debugging why.

Bill-Becker · 2026-05-01T22:49:04Z

@rathod-b Can you also implement this check on resulting battery size with respect to the size_class as we do for PV, so it throws a warning if the size is outside the size_class range?

REopt.jl/src/results/pv.jl

Line 49 in bb85c6d

if optimal_size < min_size || optimal_size > max_size

Co-authored-by: Copilot <[email protected]>

…tch with REopt-solved size Co-authored-by: Copilot <[email protected]>

Bill-Becker · 2026-05-05T18:08:45Z

@rathod-b I just merged develop into this branch and resolved the conflicts (not much), but I'll let you make the BESS O&M default cost update. There's one test that is explicitly checking for the 0.025, so we either need to hard-code that input or change the expected fraction to 0.04 in the test.

I updated this.

Bill-Becker · 2026-05-05T18:08:57Z

@rathod-b Can you also implement this check on resulting battery size with respect to the size_class as we do for PV, so it throws a warning if the size is outside the size_class range?

REopt.jl/src/results/pv.jl

Line 49 in bb85c6d

if optimal_size < min_size || optimal_size > max_size

I implemented this.

…ize_class

Co-authored-by: Copilot <[email protected]>

rathod-b added 2 commits December 23, 2025 14:59

Add size class for bess kw

b722df3

Only adds size class in inputs processing, other code modifications pending.

Updates for size class capability

e8b7b30

Bill-Becker requested changes Dec 31, 2025

View reviewed changes

rathod-b and others added 7 commits December 31, 2025 12:57

Update electric_storage.jl

7ff7b32

bug fix for existing tests

Minor cleanup and bug fixes

19d7641

Update runtests.jl

7e797a6

Update electric_storage_defaults.json

31475e5

Update costs and descriptions

Update runtests.jl

315f43b

fix broken test

Merge branch 'develop' into electric_storage_size_class

f583b14

Update runtests.jl

9a65eb4

Bugfix and update to latest costs used

Bill-Becker reviewed Feb 23, 2026

View reviewed changes

Merge branch 'develop' into electric_storage_size_class

59b883d

rathod-b marked this pull request as ready for review April 17, 2026 20:10

rathod-b added 2 commits April 17, 2026 16:11

Address PR comments

6badb4f

Update electric_storage_defaults.json

e865b57

Update default costs to use 2025 costs converted to 2025$ instead of 2026 costs converted to 2025$. Also change size class names per feedback.

Bill-Becker requested changes May 1, 2026

View reviewed changes

Merge branch 'develop' into electric_storage_size_class

afe13c3

Bill-Becker and others added 4 commits May 5, 2026 09:23

Remove debuggin @info statements

c811b28

Update expected ElectricStorage default costs after update

e415def

Update ElectricStorage O&M cost to 4% of installed cost

a775aa3

Co-authored-by: Copilot <[email protected]>

Add warning and test if chosen ElectricStorage size_class does not ma…

96ae469

…tch with REopt-solved size Co-authored-by: Copilot <[email protected]>

Bill-Becker and others added 2 commits May 5, 2026 12:33

Merge remote-tracking branch 'origin/develop' into electric_storage_s…

4fa9ff4

…ize_class

Fix "stor" versus "s" in ElectricStorage constructors

ece18e7

Co-authored-by: Copilot <[email protected]>


		@info s.installed_cost_per_kw, s.size_class, s.electric_load_annual_peak, s.electric_load_average_peak

		installed_cost_per_kw, installed_cost_per_kwh, installed_cost_constant, size_class,

Conversation

rathod-b commented Dec 30, 2025

Uh oh!

Bill-Becker left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Bill-Becker left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Bill-Becker commented May 1, 2026

Uh oh!

Bill-Becker commented May 1, 2026

Uh oh!

Bill-Becker commented May 1, 2026

Uh oh!

Bill-Becker commented May 5, 2026

Uh oh!

Bill-Becker commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants