Hot Fix for Backwards Compatibility of Downloadable Spreadsheet

[Bill-Becker]

PRs:

• Hot Fix: Backwards compatibility for results download spreadsheet #638

[Copilot]

Pull Request Overview

This PR fixes a backwards compatibility issue with the downloadable spreadsheet by ensuring that values of type None are handled correctly when performing arithmetic fixes. The changes include:

• Modifying the safe_get helper to return 0 for None values.
• Updating key references in the custom table configurations to use the new "Financial" field names.
• Patching deployment YAML configuration by quoting the maxSurge value for consistency.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
reoptjl/custom_table_helpers.py	Updated safe_get to handle None values explicitly.
reoptjl/custom_table_config.py	Updated key references from CHP to Financial for cost calculations.
CHANGELOG.md	Updated release notes to reflect the hot fix.
.helm/values.production.yaml	Corrected YAML formatting by quoting maxSurge value.

Comments suppressed due to low confidence (1)

.helm/values.production.yaml:16

• Changing maxSurge to a quoted string ensures proper YAML parsing, but please verify that downstream deployment scripts expect this field as a string to avoid potential issues.

    maxSurge: "0%"

[Copilot]

The updated safe_get function now forces a return value of 0 when a key exists with a None value or when default is None. It would be helpful to update the docstring to clearly explain that None is automatically converted to 0 to avoid unintended behavior.

Suggested change

	"""Safely get a value from a dictionary with a default fallback."""
	"""
	Safely get a value from a dictionary with a default fallback.
	If the key exists in the dictionary with a value of None, or if the default
	value is explicitly set to None, the function will return 0. This ensures
	that None values are always converted to 0.
	Args:
	df (Dict[str, Any]): The dictionary to retrieve the value from.
	key (str): The key to look up in the dictionary.
	default (Any, optional): The default value to return if the key is not found.
	Defaults to 0. If set to None, it will be treated as 0.
	Returns:
	Any: The value associated with the key, or the default value (converted to 0 if None).
	"""