v3.13.0#646
Merged
Merged
Conversation
Also remove debug print statement
PV and Battery Cost Update, GHP Inputs, CapEx Constraints
Collaborator
Author
|
@bpulluta I tagged you as a reviewer mainly for the PV and Battery Cost updates - not for the "add CapEx constraints" or the "add GHP inputs/outputs" related stuff. Those have already been reviewed. |
bpulluta
approved these changes
Jun 18, 2025
Collaborator
bpulluta
left a comment
bpulluta
left a comment
There was a problem hiding this comment.
@Bill-Becker, all of my internal tests are passing for me as it pertains to PV costs. The PV size classes seem to be working correctly on the API side.
no changes to suggest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR:
Which was an aggregation of PRs:
This pull request introduces a series of enhancements and updates across multiple components of the REopt model. The changes include new features for financial and technology inputs, updates to default values, and the addition of new endpoints and migrations to support these features. Below is a summary of the most important changes grouped by theme:
Financial and Technology Inputs
min_initial_capital_costs_before_incentivesandmax_initial_capital_costs_before_incentivesto define capital cost constraints.ElectricStorageInputsfor fixed installation and replacement costs, and updated default values for cost parameters. [1] [2] [3]size_classinput toPVInputsfor categorizing PV systems, along with new cost-related outputs (installed_cost_per_kw,om_cost_per_kw).Ground Heat Pump (GHP) Enhancements
max_number_of_boreholes,max_ton) and load splitting (load_served_by_ghp).Code Updates and Endpoints
reoptjl/models.pyandvalidators.pyto support new GHP inputs and validate defaults./pv_cost_defaultsto retrieve PV cost defaults based on user inputs. [1] [2]Migrations
Miscellaneous Updates
PV.installed_cost_per_kw,PV.om_cost_per_kw, and electric storage cost parameters to reflect the latest cost data.These changes collectively improve the functionality, configurability, and accuracy of the REopt model, particularly for financial and technology-related analyses.