Update Battery Compare Cases macro

[mjprilliman]

Pull Request Template

Description

-Add roundtrip efficiency in summary table for Battery Compare Cases macro

-To test:
-open attached SAM file
-Simulate both cases
-Go to macros -> Battery Compare Cases, run macro with all cases
-See results

Fixes #1973

batt_macro_test.zip

Checklist

• requires help revision and I added that label
• adds, removes, modifies, or deletes variables in existing compute modules
• adds a new compute module
• changes defaults
• [x ] I've tagged this PR to a milestone

[cpaulgilman]

Thanks for adding the roundtrip efficiency to the Battery Compare Cases macro.

One small fix. The footer says:

This report was generated using the System Advisor Model testMacro on:

It should say

This report was generated using the System Advisor Model Battery Compare Cases macro on:

Also, I got thrown off because there's a "Compare Cases" and a "Battery Compare Cases" macro. As a separate issue, I would recommend combining the macros into a single "Compare Cases" macro that can handle battery and non-battery cases.

[mjprilliman]

Thanks for adding the roundtrip efficiency to the Battery Compare Cases macro.

One small fix. The footer says:

This report was generated using the System Advisor Model testMacro on:

It should say

This report was generated using the System Advisor Model Battery Compare Cases macro on:

Also, I got thrown off because there's a "Compare Cases" and a "Battery Compare Cases" macro. As a separate issue, I would recommend combining the macros into a single "Compare Cases" macro that can handle battery and non-battery cases.

That is clunky to do right now due to how we prepare the html code to generate the report, but I will mark it as a future issue to address.