Skip to content

Add optical table options to Trough model #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taylorbrown75 wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Add optical table options to Trough model #2182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf8334f
Add optical table to CSP trough.
taylorbrown75 Apr 29, 2026
79b64f9
Update trough IPH defaults for optical tables
taylorbrown75 Apr 29, 2026
f93f86a
Merge branch 'develop' into trough_optical_table
taylorbrown75 Apr 29, 2026
ccc9207
Modify optical table layout.
taylorbrown75 Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
797 changes: 774 additions & 23 deletions deploy/runtime/defaults/Physical Trough IPH_Commercial.json
View file
Open in desktop

Large diffs are not rendered by default.

795 changes: 773 additions & 22 deletions deploy/runtime/defaults/Physical Trough IPH_LCOH Calculator.json
View file
Open in desktop

Large diffs are not rendered by default.

795 changes: 773 additions & 22 deletions deploy/runtime/defaults/Physical Trough IPH_None.json
View file
Open in desktop

Large diffs are not rendered by default.

89 changes: 66 additions & 23 deletions deploy/runtime/defaults/Physical Trough IPH_Single Owner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@
8.0
],
"DISCARD_UNUSED_latitude": 0.0,
"DISP_opt_model_1": 2.0,
"DISP_opt_model_2": 2.0,
"DISP_opt_model_3": 2.0,
"DISP_opt_model_4": 2.0,
"D_2": [
[
0.076,
Expand Down Expand Up @@ -775,6 +779,38 @@
"Min_rnr_xpans": 1.0,
"N_hdr_per_xpan": 2.0,
"N_max_hdr_diams": 10.0,
"OpticalTable_1": [
[
2.0,
1.0,
2.0,
1.0
]
],
"OpticalTable_2": [
[
2.0,
1.0,
2.0,
1.0
]
],
"OpticalTable_3": [
[
2.0,
1.0,
2.0,
1.0
]
],
"OpticalTable_4": [
[
2.0,
1.0,
2.0,
Comment on lines +784 to +810
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default OpticalTable_1 (and similarly _2/_3/_4 in this file) is a 1x4 placeholder matrix, unlike other defaults that seed a structured table with header row/column values. If a user selects a table-based optical model, this placeholder shape is likely not a valid optical table and could cause downstream parsing/compute failures. Provide a valid minimal table format consistent with what the compute module expects (or seed the same full template table used in the other defaults).

Suggested change
2.0,
1.0,
2.0,
1.0
]
],
"OpticalTable_2": [
[
2.0,
1.0,
2.0,
1.0
]
],
"OpticalTable_3": [
[
2.0,
1.0,
2.0,
1.0
]
],
"OpticalTable_4": [
[
2.0,
1.0,
2.0,
0.0,
0.0
],
[
0.0,
1.0
]
],
"OpticalTable_2": [
[
0.0,
0.0
],
[
0.0,
1.0
]
],
"OpticalTable_3": [
[
0.0,
0.0
],
[
0.0,
1.0
]
],
"OpticalTable_4": [
[
0.0,
0.0
],
[
0.0,

Copilot uses AI. Check for mistakes.
1.0
]
],
"P_a": [
[
0.0001,
Expand Down Expand Up @@ -1110,9 +1146,9 @@
],
"analysis_period": 25.0,
"analysis_period_warning": "",
"annual_albedo": 0.21716438274677489,
"annual_albedo": 0.21716438274677486,
"annual_beam": 7.364082191780821,
"annual_diffuse": 1.3397808219178085,
"annual_diffuse": 1.3397808219178083,
"annual_global": 5.838191780821918,
"annual_snow": NaN,
"annual_tdry": 18.126141552511418,
Expand Down Expand Up @@ -1281,7 +1317,7 @@
"csp.dtr.tes.htf_min_opt_temp": 238.0,
"csp.dtr.tes.min_fluid_volume": 39.67439516694667,
"csp.dtr.tes.thermal_capacity": 30.0,
"csp.pt.par.calc.aux": 0.12121,
"csp.pt.par.calc.aux": 0.12120999999999999,
"csp.pt.par.calc.bop": 0.0,
"csp.pt.tes.htf_density": 1872.488,
"csp.pt.tes.tank_diameter": 7.107391202241459,
Expand Down Expand Up @@ -1518,7 +1554,7 @@
"csp_dtr_hce_var4_rated_heat_loss_2": 0.0,
"csp_dtr_hce_var4_rated_heat_loss_3": 0.0,
"csp_dtr_hce_var4_rated_heat_loss_4": 0.0,
"csp_dtr_loop_hce_heat_loss": 0.9745454545454548,
"csp_dtr_loop_hce_heat_loss": 0.9745454545454547,
"csp_dtr_sca_ap_length_1": 21.0,
"csp_dtr_sca_ap_length_2": 14.375,
"csp_dtr_sca_ap_length_3": 14.375,
Expand Down Expand Up @@ -1556,25 +1592,25 @@
0.0
]
],
"csp_dtr_sca_calc_end_loss_1": 0.9996718942883744,
"csp_dtr_sca_calc_end_loss_2": 0.9996434127184016,
"csp_dtr_sca_calc_end_loss_3": 0.9996434127184016,
"csp_dtr_sca_calc_end_loss_4": 0.9996434127184016,
"csp_dtr_sca_calc_end_loss_1": 0.9996718942883743,
"csp_dtr_sca_calc_end_loss_2": 0.9996434127184017,
"csp_dtr_sca_calc_end_loss_3": 0.9996434127184017,
"csp_dtr_sca_calc_end_loss_4": 0.9996434127184017,
"csp_dtr_sca_calc_end_losses": [
[
0.9996718942883744,
0.9996434127184016,
0.9996434127184016,
0.9996434127184016
0.9996718942883743,
0.9996434127184017,
0.9996434127184017,
0.9996434127184017
]
],
"csp_dtr_sca_calc_iam_1": 0.9960610689663656,
"csp_dtr_sca_calc_iam_1": 0.9960610689663657,
"csp_dtr_sca_calc_iam_2": 1.0018753305435045,
"csp_dtr_sca_calc_iam_3": 1.0018753305435045,
"csp_dtr_sca_calc_iam_4": 1.0018753305435045,
"csp_dtr_sca_calc_iams": [
[
0.9960610689663656,
0.9960610689663657,
1.0018753305435045,
1.0018753305435045,
1.0018753305435045
Expand All @@ -1595,11 +1631,11 @@
0.8484936096,
0.8484936096
],
"csp_dtr_sca_calc_theta": 0.1514182598841343,
"csp_dtr_sca_calc_theta_1": 0.1514182598841343,
"csp_dtr_sca_calc_theta_2": 0.1514182598841343,
"csp_dtr_sca_calc_theta_3": 0.1514182598841343,
"csp_dtr_sca_calc_theta_4": 0.1514182598841343,
"csp_dtr_sca_calc_theta": 0.15141825988413427,
"csp_dtr_sca_calc_theta_1": 0.15141825988413427,
"csp_dtr_sca_calc_theta_2": 0.15141825988413427,
"csp_dtr_sca_calc_theta_3": 0.15141825988413427,
"csp_dtr_sca_calc_theta_4": 0.15141825988413427,
"csp_dtr_sca_calc_zenith": 0.15062193308923828,
"csp_dtr_sca_calc_zenith_1": 0.15062193308923828,
"csp_dtr_sca_calc_zenith_2": 0.15062193308923828,
Expand Down Expand Up @@ -10730,7 +10766,7 @@
"f_htfmax": 1.2,
"f_htfmax_actual": 0.5460258809863511,
"f_htfmin": 0.25,
"f_htfmin_actual": 0.04550215674886259,
"f_htfmin_actual": 0.045502156748862588,
"f_tc_cold": 2.0,
"f_turb_tou_periods": [
1.0,
Expand Down Expand Up @@ -10975,7 +11011,7 @@
0.0
]
],
"lat": 32.13,
"lat": 32.130001068115237,
"lib_A_aperture": 1320.0,
"lib_AbsorberMaterial": 0.0,
"lib_AnnulusGas_1": 2.0,
Expand Down Expand Up @@ -11719,7 +11755,7 @@
"library_folder_list": "x",
"library_paths": "\"\"",
"loan_moratorium": 0.0,
"lon": -110.94,
"lon": -110.94000244140625,
"loop_optical_efficiency": 0.7410044526207242,
"m_dot_hs_ext_des_ui": NaN,
"m_dot_htfmax": 12.0,
Expand Down Expand Up @@ -11748,7 +11784,7 @@
"nSCA": 4.0,
"nameplate": 5.0,
"nodes": 2000.0,
"nominal_discount_rate": 9.060000000000004,
"nominal_discount_rate": 9.060000000000003,
"non_solar_field_land_area_multiplier": 1.1,
"northsouth_field_sep": 20.0,
"object 11": 0.0,
Expand All @@ -11765,6 +11801,12 @@
"om_production_heat": [
2.0
],
"opt_model": [
3.0,
3.0,
3.0,
3.0
],
"p_start": 0.021,
"payment_option": 0.0,
"pb_fixed_par": 0.0055,
Expand Down Expand Up @@ -11837,6 +11879,7 @@
"sales_tax_rate": 5.0,
"salvage_percentage": 0.0,
"salvage_value": 0.0,
"sca_1_is_shown": 1.0,
"sca_2_is_shown": 1.0,
"sca_3_is_shown": 1.0,
"sca_4_is_shown": 1.0,
Expand Down
Loading
Loading