Sampling regions characteristic#525
Conversation
| def _run_sampling_local(self): | ||
| subprocess.run( | ||
| [ | ||
| self.parent().openstudio_exe(), |
There was a problem hiding this comment.
Not totally sure why we needed the openstudio cli to run the quota sampler script (possibly pre-dates the run_sampling / run_sampling_lib split?), but it seems to work fine using system ruby.
| def _run_sampling_local(self): | ||
| subprocess.run( | ||
| [ | ||
| "python", |
There was a problem hiding this comment.
Related to https://github.com/NatLabRockies/buildstockbatch/pull/525/changes#r3390798176, another reason to not use the openstudio cli is that I tried it with this stratified sampler script (python), and ran into a bunch of issues related to missing packages (and needing to use --python_path), joblib/multiprocessing and using the wrong executable, etc. It's probably possible to use the openstudio cli, but it seems to work fine using system python.
| # samplers_path = buildstock_path / "samplers" | ||
| # if samplers_path.exists(): | ||
| # sampler_path = sim_path / "samplers" | ||
| # (sampler_path).symlink_to(samplers_path, target_is_directory=True) | ||
| # else: | ||
| # sampler_path = None |
There was a problem hiding this comment.
Not totally sure if I need this yet.
2 participants
Pull Request Description
Companion PR: NatLabRockies/resstock#1418
Checklist
Not all may apply
minimum_coveragein.github/workflows/coverage.ymlas necessary.