Update isort requirement from <8,>=5 to >=5,<9#1188
Conversation
Updates the requirements on [isort](https://github.com/PyCQA/isort) to permit the latest version. - [Release notes](https://github.com/PyCQA/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md) - [Commits](PyCQA/isort@5.0.0...8.0.1) --- updated-dependencies: - dependency-name: isort dependency-version: 8.0.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
|
@copilot , would any test fail if this didn't work? |
|
We may need to alter the pre-commit workflow as well, as there appears to be some deprecated use of EDIT: the updated 'stages' in .pre-commit-config.yaml seems to work in all currently supported versions of isort. EDIT 2: EDIT 3: Seems fine anyway to update the |
Avoids deprecation warning and works on isort 5 through 8
misi9170
left a comment
There was a problem hiding this comment.
I've tested running various version of isort, including v5 and v8, and no changes appear to be needed to the code base so I'm happy to proceed and merge.
Updates the requirements on isort to permit the latest version.
Changelog
Sourced from isort's changelog.
... (truncated)
Commits
a333737Merge pull request #2463 from FinlayTheBerry/issue/2461878ba7eAdded compression to stdlibs for Python 3.14 in isort/stdlibs/py314.pyb5f06a7Merge pull request #2459 from Fridayai700/fix-unindented-comment-corruption3459bdeMerge pull request #2460 from PyCQA/DanielNoord-patch-16e70bb6Update CHANGELOG for version 8.0.0fd2514bFix unindented comments being corrupted in indented blocksb0f2dabMerge pull request #2458 from skv0zsneg/issue/1882313797bFix lint.7d3a6f5Add ignore for cyclomatic complexity check.6b9f895Remove debug prints.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)