Skip to content

Update isort requirement from <8,>=5 to >=5,<9#1188

Merged
misi9170 merged 2 commits intodevelopfrom
dependabot/pip/develop/isort-gte-5-and-lt-9
Mar 3, 2026
Merged

Update isort requirement from <8,>=5 to >=5,<9#1188
misi9170 merged 2 commits intodevelopfrom
dependabot/pip/develop/isort-gte-5-and-lt-9

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Mar 1, 2026

Updates the requirements on isort to permit the latest version.

Changelog

Sourced from isort's changelog.

Changelog

NOTE: isort follows the semver versioning standard. Find out more about isort's release policy here.

Unreleased

8.0.0 February 19 2026

  • Removed --old-finders and --magic-placement flags and old_finders configuration option. The legacy finder logic that relied on environment introspection has been removed (#2445) @​joao-faria-dev
  • Update the plone profile to not clash with black (#2456) @​ale-rt

6.1.0 October 1 2025

6.0.1 Febuary 26 2025

6.0.0 January 27 2025

5.13.2 December 13 2023

5.13.1 December 11 2023

5.13.0 December 9 2023

... (truncated)

Commits
  • a333737 Merge pull request #2463 from FinlayTheBerry/issue/2461
  • 878ba7e Added compression to stdlibs for Python 3.14 in isort/stdlibs/py314.py
  • b5f06a7 Merge pull request #2459 from Fridayai700/fix-unindented-comment-corruption
  • 3459bde Merge pull request #2460 from PyCQA/DanielNoord-patch-1
  • 6e70bb6 Update CHANGELOG for version 8.0.0
  • fd2514b Fix unindented comments being corrupted in indented blocks
  • b0f2dab Merge pull request #2458 from skv0zsneg/issue/1882
  • 313797b Fix lint.
  • 7d3a6f5 Add ignore for cyclomatic complexity check.
  • 6b9f895 Remove debug prints.
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [isort](https://github.com/PyCQA/isort) to permit the latest version.
- [Release notes](https://github.com/PyCQA/isort/releases)
- [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md)
- [Commits](PyCQA/isort@5.0.0...8.0.1)

---
updated-dependencies:
- dependency-name: isort
  dependency-version: 8.0.1
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot Bot added the package For pull requests and features that are to do with the FLORIS as a python package label Mar 1, 2026
@paulf81
Copy link
Copy Markdown
Collaborator

paulf81 commented Mar 2, 2026

@copilot , would any test fail if this didn't work?

Copy link
Copy Markdown

Copilot AI commented Mar 2, 2026

@paulf81 I've opened a new pull request, #1190, to work on those changes. Once the pull request is ready, I'll request review from you.

@misi9170
Copy link
Copy Markdown
Collaborator

misi9170 commented Mar 2, 2026

We may need to alter the pre-commit workflow as well, as there appears to be some deprecated use of isort there. I'm now testing whether this means we need to raise the mimimum isort version.

EDIT: the updated 'stages' in .pre-commit-config.yaml seems to work in all currently supported versions of isort.

EDIT 2: stages is related to pre_commit, not isort. Checking everything is still consistent.

EDIT 3: Seems fine anyway to update the stages here. Not directly related to isort, but might as well take the opportunity to address the deprecation warning.

Avoids deprecation warning and works on isort 5 through 8
@misi9170 misi9170 self-requested a review March 3, 2026 03:40
Copy link
Copy Markdown
Collaborator

@misi9170 misi9170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested running various version of isort, including v5 and v8, and no changes appear to be needed to the code base so I'm happy to proceed and merge.

@misi9170 misi9170 merged commit 6e4d5ae into develop Mar 3, 2026
63 of 66 checks passed
@misi9170 misi9170 deleted the dependabot/pip/develop/isort-gte-5-and-lt-9 branch March 3, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package For pull requests and features that are to do with the FLORIS as a python package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants