fix: correct tilt_interp parameter type in compute_tilt_angles_for_fl…#1192
Merged
Conversation
…oating_turbines - Change tilt_interp parameter type from dict[str, interp1d] to interp1d|None - This aligns with the function's actual usage where it expects a single interpolation function or None
Collaborator
|
Good catch and thanks for fixing this @zredb ! I've made one very minor formatting change to the type hint, just to match with other type hints that accept a range of types ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…oating_turbines