Bug fix: Finalize Farm attributes#665
Merged
rafmudaf merged 5 commits intoNatLabRockies:developfrom Jul 6, 2023
Merged
Conversation
Collaborator
Author
|
ping @bayc - I think this PR is good, but I'd like to get your eyes on it to double check |
rafmudaf
added a commit
that referenced
this pull request
Jul 27, 2023
* Arrange attribute declarations by shape and sort * Add missing attribute declarations * Remove unused attribute * Add comments requesting more info * Bug fix: unsort arrays
rafmudaf
added a commit
to rafmudaf/floris
that referenced
this pull request
Jul 27, 2023
* Arrange attribute declarations by shape and sort * Add missing attribute declarations * Remove unused attribute * Add comments requesting more info * Bug fix: unsort arrays Update version to v3.4.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finalize Farm attributes and other Farm clean up
This pull request finalized three attributes on the Farm class:
Currently, these are created when the Farm attributes are expanded using the
Farm.construct_*methods. However, these particular attributes are initially 1D with the length being the number of turbines. After the wake calculation, they must be expanded again viaFarm.finalize()so that they have the three dimensions expected by the post-processing routines inTurbine, that is(n wind directions, n wind speeds, n turbines).Thanks to @MarcusBecker-GitHub for reporting this bug in #664.
Additionally, this pull request declares some Farm-class attributes that were otherwise added to the class after init. The attributes are also grouped into whether they have a corresponding
_sortedversion.Related issue
#664
Impacted areas of the software
Only changes are in farm.py
Additional supporting information
Since this is a bug, it could be released as v3.4.1 along with #663.