Potential fix to reflections at AMR levels#158
Merged
marchdf merged 32 commits intoNatLabRockies:mainfrom Oct 31, 2025
Merged
Conversation
…re macrodata_to_equilibrium and is possible only after f_to_macrodata. Sequence was correct only in collision
marchdf
changed the title
Collaborator
|
Can you put |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
added 2 commits
October 20, 2025 15:56
marchdf
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix to AMR reflections. compute_q_corrections is needed before macrodata_to_equilibrium and is possible only after f_to_macrodata. Sequence was correct only in collision