Skip to content

Generate detailed setpoints#1239

Closed
rajeee wants to merge 13 commits into
developfrom
detailed_setpoints
Closed

Generate detailed setpoints#1239
rajeee wants to merge 13 commits into
developfrom
detailed_setpoints

Conversation

@rajeee

@rajeee rajeee commented May 3, 2024

Copy link
Copy Markdown
Contributor

Pull Request Description

Generate detailed setpoints from the schedule generator. Ensure that the setpoint follows the exact same values as the existing weekday/weekend setpoint schedule. This is in preparation of load flexibility analysis that will need to modify the setpoints.
This PR also simplifies the handling of the offset period. Instead of providing offset schedule for each shifting (+5 hour to -5 hour), ResStock only needs to pass the shift hours. Shifting can also be set to "auto" which will result in random shifting of +-5 hours, further simplifying the workflow.

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

@rajeee rajeee marked this pull request as draft May 3, 2024 21:33
@shorowit

Copy link
Copy Markdown
Contributor

I was reminded of @joseph-robertson's similar PR here. How is this different?

@rajeee

rajeee commented May 20, 2024

Copy link
Copy Markdown
Contributor Author

I was reminded of @joseph-robertson's similar PR here. How is this different?

I think it's similar goal. That PR is quite old now though and possibly cannot be merged. I am going to close this PR too - have opened one in OS-HPXML instead: NatLabRockies/OpenStudio-HPXML#1726 and will later have the supporting PR in ResStock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants