Generate detailed setpoints#1239
Closed
rajeee wants to merge 13 commits into
Closed
Conversation
Contributor
|
I was reminded of @joseph-robertson's similar PR here. How is this different? |
Contributor
Author
I think it's similar goal. That PR is quite old now though and possibly cannot be merged. I am going to close this PR too - have opened one in OS-HPXML instead: NatLabRockies/OpenStudio-HPXML#1726 and will later have the supporting PR in ResStock. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Generate detailed setpoints from the schedule generator. Ensure that the setpoint follows the exact same values as the existing weekday/weekend setpoint schedule. This is in preparation of load flexibility analysis that will need to modify the setpoints.
This PR also simplifies the handling of the offset period. Instead of providing offset schedule for each shifting (+5 hour to -5 hour), ResStock only needs to pass the shift hours. Shifting can also be set to "auto" which will result in random shifting of +-5 hours, further simplifying the workflow.
Checklist
Not all may apply:
openstudio tasks.rb update_measureshas been run