Skip to content

Ssc 1378 custom generation lifetime#1384

Merged
brtietz merged 16 commits intodevelopfrom
ssc_1378_custom_generation_lifetime
May 7, 2026
Merged

Ssc 1378 custom generation lifetime#1384
brtietz merged 16 commits intodevelopfrom
ssc_1378_custom_generation_lifetime

Conversation

@brtietz
Copy link
Copy Markdown
Collaborator

@brtietz brtietz commented Apr 6, 2026

Pull Request Template

Description

Add lifetime mode to custom generation profile with appropriate additional data handling

Fixes #1371 and #1378

Corresponding branches and PRs:

ssc_1378_custom_generation_lifetime on SAM NatLabRockies/SAM#2166

Develop of other branches

Unit Test Impact:

New tests to capture derate handling and lifetime mode

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

Reminders- this section can be deleted

[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).

[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 6, 2026

Coverage Report for CI Build 25523574163

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.009%) to 56.293%

Details

  • Coverage increased (+0.009%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 329 coverage regressions across 6 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

329 previously-covered lines in 6 files lost coverage.

File Lines Losing Coverage Coverage
ssc/ssc/cmod_merchantplant_eqns.cpp 90 55.2%
ssc/ssc/common.cpp 88 76.07%
ssc/ssc/cmod_windpower.cpp 53 86.87%
ssc/shared/lib_windfile.cpp 48 62.07%
ssc/ssc/cmod_custom_generation.cpp 37 73.19%
or-tools-9.14/install_release/include/eigen3/Eigen/src/Core/util/Memory.h 13 48.2%

Coverage Stats

Coverage Status
Relevant Lines: 121203
Covered Lines: 68229
Line Coverage: 56.29%
Coverage Strength: 3455191.51 hits per line

💛 - Coveralls

@brtietz brtietz merged commit d207edc into develop May 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a lifetime input option to custom generation profile plant

3 participants