Skip to content

Itc basis updates#1395

Open
brtietz wants to merge 10 commits intodevelopfrom
itc_basis_updates
Open

Itc basis updates#1395
brtietz wants to merge 10 commits intodevelopfrom
itc_basis_updates

Conversation

@brtietz
Copy link
Copy Markdown
Collaborator

@brtietz brtietz commented May 6, 2026

Pull Request Template

Description

Add code to common financial to handle new ITC basis input options. A few variables that previously held bools now function as 0-1 fractions.

Corresponding branches and PRs:

SAM branch itc_basis_updates NatLabRockies/SAM#2187

develop for other branches

Unit Test Impact:

New tests written for common financial functions.

Existing tests using the old manual paradigm should remain unchanged.

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

@coveralls
Copy link
Copy Markdown

coveralls commented May 7, 2026

Coverage Report for CI Build 25566865746

Warning

No base build found for commit fe79123 on develop.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 56.31%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 121282
Covered Lines: 68294
Line Coverage: 56.31%
Coverage Strength: 3452434.63 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants