Fuel cell schedule period warning#1400
Open
mjprilliman wants to merge 4 commits into
Open
Conversation
5 tasks
Coverage Report for CI Build 26650867183Coverage decreased (-0.005%) to 56.322%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions12 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
…cell" for clarity.
cpaulgilman
approved these changes
May 29, 2026
Collaborator
cpaulgilman
left a comment
There was a problem hiding this comment.
I revised error messages to more clearly differentiate between battery and fuel cell manual dispatch errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
-Adds checking for max manual dispatch period in fuel cell dispatch (before it was running undefined periods with no message)
-See NatLabRockies/SAM#2196
Fixes # (issue(s))
Corresponding branches and PRs:
Same branch for SAM, develop elsewhere
[ link any corresponding PRs in other repos, i.e. NREL/ssc#x ] NatLabRockies/SAM#2196
Unit Test Impact:
Checklist
Reminders- this section can be deleted
[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)