Skip to content

Fuel cell schedule period warning#1400

Open
mjprilliman wants to merge 4 commits into
developfrom
fuel_cell_sched_warning
Open

Fuel cell schedule period warning#1400
mjprilliman wants to merge 4 commits into
developfrom
fuel_cell_sched_warning

Conversation

@mjprilliman
Copy link
Copy Markdown
Collaborator

Description

-Adds checking for max manual dispatch period in fuel cell dispatch (before it was running undefined periods with no message)
-See NatLabRockies/SAM#2196

Fixes # (issue(s))

Corresponding branches and PRs:

Same branch for SAM, develop elsewhere

[ link any corresponding PRs in other repos, i.e. NREL/ssc#x ] NatLabRockies/SAM#2196

Unit Test Impact:

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

Reminders- this section can be deleted

[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).

[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)

@mjprilliman mjprilliman added this to the SAM 2026 Release milestone May 26, 2026
@mjprilliman mjprilliman requested a review from cpaulgilman May 26, 2026 20:33
@mjprilliman mjprilliman self-assigned this May 26, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented May 26, 2026

Coverage Report for CI Build 26650867183

Coverage decreased (-0.005%) to 56.322%

Details

  • Coverage decreased (-0.005%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 12 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

12 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
ssc/ssc/cmod_fuelcell.cpp 12 88.79%

Coverage Stats

Coverage Status
Relevant Lines: 121741
Covered Lines: 68567
Line Coverage: 56.32%
Coverage Strength: 3438270.6 hits per line

💛 - Coveralls

Copy link
Copy Markdown
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I revised error messages to more clearly differentiate between battery and fuel cell manual dispatch errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants