Skip to content

Marine energy release updates#1401

Open
mjprilliman wants to merge 4 commits into
developfrom
me-beta-fixes
Open

Marine energy release updates#1401
mjprilliman wants to merge 4 commits into
developfrom
me-beta-fixes

Conversation

@mjprilliman
Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

-Add checks for faulty data from wave file downloads
-Update checks for utility rates in PPA financials to remove unused electricity purchase inputs

Fixes # (issue(s))

Corresponding branches and PRs:

same branch name of SAM, rest develop

[ link any corresponding PRs in other repos, i.e. NREL/ssc#x ]

Unit Test Impact:

[ new tests written? ]

[ expected changes in unit tests or speed of tests? ]

[ expected changes in test_results files? ]

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

Reminders- this section can be deleted

[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).

[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)

@mjprilliman mjprilliman added this to the SAM 2026 Release milestone May 27, 2026
@mjprilliman mjprilliman requested a review from janinefreeman May 27, 2026 14:50
@mjprilliman mjprilliman self-assigned this May 27, 2026
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 26518529681

Coverage increased (+0.003%) to 56.33%

Details

  • Coverage increased (+0.003%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 327 coverage regressions across 6 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

327 previously-covered lines in 6 files lost coverage.

File Lines Losing Coverage Coverage
ssc/ssc/cmod_singleowner_heat.cpp 141 77.03%
ssc/ssc/cmod_singleowner.cpp 59 91.99%
ssc/ssc/cmod_levpartflip.cpp 41 93.63%
ssc/ssc/cmod_saleleaseback.cpp 40 93.33%
ssc/ssc/cmod_equpartflip.cpp 37 93.33%
ssc/ssc/cmod_wavefile.cpp 9 72.92%

Coverage Stats

Coverage Status
Relevant Lines: 121737
Covered Lines: 68574
Line Coverage: 56.33%
Coverage Strength: 3438412.21 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants