Marine energy release updates#1401
Open
mjprilliman wants to merge 4 commits into
Open
Conversation
5 tasks
Coverage Report for CI Build 26518529681Coverage increased (+0.003%) to 56.33%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions327 previously-covered lines in 6 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
-Add checks for faulty data from wave file downloads
-Update checks for utility rates in PPA financials to remove unused electricity purchase inputs
Fixes # (issue(s))
Corresponding branches and PRs:
same branch name of SAM, rest develop
[ link any corresponding PRs in other repos, i.e. NREL/ssc#x ]
Unit Test Impact:
[ new tests written? ]
[ expected changes in unit tests or speed of tests? ]
[ expected changes in test_results files? ]
Checklist
Reminders- this section can be deleted
[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)