Skip to content

GETEM release updates#1402

Open
mjprilliman wants to merge 14 commits into
developfrom
GETEM-SAM
Open

GETEM release updates#1402
mjprilliman wants to merge 14 commits into
developfrom
GETEM-SAM

Conversation

@mjprilliman
Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

-Updates for ATB process
-Updated PPI tables
-Fix issues with temperature decline calculation
-Update Gringarten to include number of fractures

Corresponding branches and PRs:

matching branch in SAM, rest develop

[ link any corresponding PRs in other repos, i.e. NREL/ssc#x ]
NatLabRockies/SAM#2198

Unit Test Impact:

[ new tests written? ]

[ expected changes in unit tests or speed of tests? ]

[ expected changes in test_results files? ]

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

Reminders- this section can be deleted

[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).

[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)

@mjprilliman mjprilliman added this to the SAM 2026 Release milestone May 27, 2026
@mjprilliman mjprilliman self-assigned this May 27, 2026
@mjprilliman mjprilliman changed the title Getem sam GETEM release updates May 27, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented May 27, 2026

Coverage Report for CI Build 26524779078

Coverage decreased (-0.009%) to 56.318%

Details

  • Coverage decreased (-0.009%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 352 coverage regressions across 4 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

352 previously-covered lines in 4 files lost coverage.

File Lines Losing Coverage Coverage
ssc/shared/lib_geothermal.cpp 185 66.26%
ssc/ssc/cmod_geothermal_costs.cpp 124 28.4%
ssc/ssc/cmod_geothermal.cpp 28 87.68%
ssc/ssc/cmod_geothermal_costs_eqns.cpp 15 0.0%

Coverage Stats

Coverage Status
Relevant Lines: 121772
Covered Lines: 68579
Line Coverage: 56.32%
Coverage Strength: 3437393.3 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants