-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BLOCKED] Create SDK extension format for AWS SDK Extension #1
Open
NathanielRN
wants to merge
524
commits into
master
Choose a base branch
from
sdk-extension-aws
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
I just put this PR up to have something to point to in discussions we are having regarding the subject of extending the SDK! This PR is BLOCKED and waiting for some progress on open-telemetry/opentelemetry-python#1233 first. |
* dropping support for python 3.4
* updating changelogs and version to 0.13b0
…text (#1146) Co-authored-by: Diego Hurtado <[email protected]>
* dropping support for python 3.4
* updating changelogs and version to 0.13b0
This uses the OpenTelemetry context management mechanism to store a ScopeShim object in order to make active return the same object as the one returned by start_active_span.
…between OpenTelemetry and OpenTracing spans (#924)
Co-authored-by: Yusuke Tsutsumi <[email protected]>
* dropping support for python 3.4
* dropping support for python 3.4
* updating changelogs and version to 0.13b0
…text (#1146) Co-authored-by: Diego Hurtado <[email protected]>
…etrics Move instrumentation system metrics
Move instrumentation flask
Move instrumentation django
Move instrumentation wsgi
Move instrumentation aiopg
ebd742e
to
4568baf
Compare
Move docker tests
a0d15bf
to
616078e
Compare
616078e
to
5674389
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, you can configure OTel to trace with custom
Resource
definitions, and can trace with customIdsGenerator
implementations.This PR provides an SDK Extension on the default provided by the OTel SDK.
The exact setup for importing as an extension of
opentelemetry.sdk.*
is being discussed in this issue.Please read my comment on the issue to see why an extension like this would be useful for the users of OpenTelemetry Python. It mentions that Java and .NET already do provide extension on the SDK like this.
This format provides a template for future backend services to provide useful SDK Extensions that are very closely related to OpenTelemetry under the
opentelemetry.sdk.extension.*
namespace.Specifically, this PR provides all the components a user needs to quickly configure their OpenTelemetry tracing to trace with the AWS X-Ray backend service. It provides:
exporters/
directory)Having this
opentelemetry-sdk-extension-aws
package makes it easy to import the necessaryAWSXrayIdsGenerator
class and create aTracerProvider
which sends IDs in the correct format right at the start. (Which will be important for downstream propagation and finally arrive at the X-Ray backend service).An Example is like this:
and subsequently,
Finally, placing vendor-specific propagators in the Contrib repo has already been discussed on the specification.
In this PR, the specification was updated to say that vendor specific implementations can be supported by the vendors or by the OpenTelemetry community. The rationale given is:
documented (unlike exporters).
tracing or metrics vendor. For example, customers of tracing vendor may still
want to use an Cloud vendor-specific propagator for requests to the services
of this cloud vendor.
shrink as vendors and users shift to W3C TraceContext.
According to this comment, the idea that vendor specific propagators could be distributed by vendors or by the OpenTelemetry community was reinforced.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The following tests also implicity test that importing an
sdk-extension/
package works properly.extract
method of AWSXRayFormat propagatorinject
method of AWSXRayFormat propagatorChecklist: