feat(web-app): add pwa install and offline shell#207
Open
EstebanCanales wants to merge 1 commit into
Open
Conversation
Add manifest metadata, service worker registration, install assets, offline fallback support, and connectivity notices for the web app. Keep the layout changes scoped to the mobile installed experience without bringing unrelated haptics work into the branch.
|
@EstebanCanales is attempting to deploy a commit to the Oppia Software Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Progressive Web App support to the Neko web app so it can be installed on mobile and desktop and behave more like a native app, while preserving the existing application layout and user flows.
The implementation includes:
Why we used Next.js manifest support instead of
next-pwaWe intentionally used the built-in Next.js App Router manifest support plus a manual service worker flow instead of adding
next-pwa.Reasoning:
In short:
manifest.tsis handled natively by Next.jsIncluded
apps/web-app/src/app/manifest.tsapps/web-app/public/sw.jsapps/web-app/public/icons/apps/web-app/public/apps/web-app/src/app/offline/page.tsxapps/web-app/src/components/pwa/apps/web-app/src/app/layout.tsxapps/web-app/src/app/providers.tsxBehavior added
Validation
npm run buildLighthouse / performance note
We also checked the baseline branch (
dev) directly on/dashboard.Baseline
devresult:499196100Preview App
https://cap.so/s/ja203jnqvs59pej