Merge changes from @elysch related to marriages, burials, photos #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit merges in a range of changes from a patch provided by elysch in #514
Moved image options to photo section Added burial prefix option to admin panel
Removed and changed various redundant code as highlighted by IDE
Swapped the option to show sex on indi times and the option to include similar events. Now option to include similar events is on it's own to make it a bit clearer it applies to multiple of the options above it.
Updated help for new functions
Updated default of show_only_first_marriage to true to keep this in line with current functionality.
Returned display of families to previous style to be more compact. This commit for combined mode only.
Removed extra table in family record so marriage details would return to being centred
Fixed issue where burial date failed to load when user is logged out. Also fixed where burial date labels were pointing to death date radio boxes
Fixing issue where clicking the photo of an individual would cause the URL for the photo to open instead of the webtrees page. Handed control of click action from SVG URL to javascript.
Changed option 'Show when type is not specified' to show or hide based on 'Show marriage type' Fixed issue where show/hide wasn't working for any show/hide boxes when settings were loaded via javascript (saved settings list or users logged out) Removed some settings from cookie for logged out users as these are not displayed on page load and are better loaded via javascript.
Fixed links in PDF so clicking on person's main photo opens the individual's page as before, but if you click other photos (e.g. birth photo, if enabled), then this opens the specific media object.
Adjusted option to add links to individuals and families. It previously stated that links were in browser, SVG, and PDF however this is not true. Browser output has been changed so the behaviour is based on the specific option for what happens when a user clicks a record. Links in SVG output have been broken for many years, and it seems you cannot have both images and links because different Graphviz renderers are used for each. Links in PDF output only work for server-side output. Therefore, I have updated this to only state it works for PDFs, and if Graphviz is not installed then the function is not available at all.
This reverts commit ae5d84f.
Removed some unused functions and unnecessary checks
Created function for repeated code, and some other minor changes based on IDE feedback
If links are enabled and SVG output selected, use browser output even when Graphviz installed on server as server Graphviz doesn't include links.
Update to help text to inform user that if they choose to include links in SVG format, the browser will render the diagram even if they have Graphviz on their server
Small corrections to code picked up by quality tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @elysch in #514 we now have a bunch of new features!
These are all off by default as i like to keep the default settings stable, but they can be found in the appearance section under various areas.
As part of the above work, I've also made the following changes:
Closes #514, #523