Add cloud formation script #258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
kcantrel
requested changes
Sep 17, 2025
Management-Utilities/ec2-user-data-iscsi-create-and-mount/EC2-cloud_formation.yaml
Outdated
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/EC2-cloud_formation.yaml
Outdated
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/EC2-cloud_formation.yaml
Outdated
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/EC2-cloud_formation.yaml
Outdated
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/EC2-cloud_formation.yaml
Outdated
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/EC2-cloud_formation.yaml
Outdated
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/EC2-cloud_formation.yaml
Outdated
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/EC2-cloud_formation.yaml
Outdated
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/EC2-cloud_formation.yaml
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/EC2-cloud_formation.yaml
Show resolved
Hide resolved
kcantrel
requested changes
Sep 19, 2025
Management-Utilities/ec2-user-data-iscsi-create-and-mount/EC2-cloud_formation.yaml
Outdated
Show resolved
Hide resolved
Management-Utilities/ec2-user-data-iscsi-create-and-mount/EC2-cloud_formation.yaml
Outdated
Show resolved
Hide resolved
kcantrel
requested changes
Sep 22, 2025
Collaborator
kcantrel
left a comment
kcantrel
left a comment
There was a problem hiding this comment.
Just a little cleanup work and it will be prefect!
Management-Utilities/ec2-user-data-iscsi-create-and-mount/EC2-cloud_formation.yaml
Outdated
Show resolved
Hide resolved
kcantrel
requested changes
Nov 11, 2025
Collaborator
kcantrel
left a comment
kcantrel
left a comment
There was a problem hiding this comment.
Two items I found:
- The username isn't prompted for by the CF template.
- The Secret infor is inconsistent between the two scripts.
| curl -o /tmp/userdata-script.sh ${LinuxUserDataUrl} | ||
| chmod +x /tmp/userdata-script.sh | ||
| # Pass parameters to the script | ||
| /tmp/userdata-script.sh "${SecretName}" "${AWSRegion}" "${ManagementEndpointIP }" "${VolumeName}" "${VolumeSize}" "${SvmName}" |
Collaborator
There was a problem hiding this comment.
I can't believe I didn't notice this before, but the CloudFormation template doesn't prompt for the username to run under. Please add a prompt for the username.
| <powershell> | ||
| Invoke-WebRequest -Uri ${WindowsUserDataUrl} -OutFile C:\userdata-script.ps1 | ||
| (Get-Content 'C:\userdata-script.ps1') | Where-Object { $_ -notmatch '^<powershell>$|^</powershell>$' } | Set-Content 'C:\userdata-script.ps1' | ||
| powershell.exe -ExecutionPolicy Bypass -File C:\userdata-script.ps1 -SecretIdParam "${SecretName}" -FSxNAdminIpParam "${ManagementEndpointIP }" -VolumeNameParam "${VolumeName}" -VolumeSizeParam "${VolumeSize}" -DriveLetterParam "${DriveLetter}" -SvmNameParam "${SvmName}" |
Collaborator
There was a problem hiding this comment.
This doesn't pass the AWSRegion parameter. This is the region where the secret is so not necessarily in the same region where the instance is running. Looking at the Windows version of the script it looks like it is expecting the SecretID to be the entire ARN, but the Linux version expects just the name and the region is separate. Personally, I prefer to just prompting for the ARN so you have one less prompt.
Of course it also doesn't pass the username.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding cloud formation script for creating EC2 instance using current scripts (powershell/bash)