29 new service also access with ssl certificate in lieu of usernamepassword #550
Conversation
Signed-off-by: bdhivya <[email protected]>
Signed-off-by: bdhivya <[email protected]>
Signed-off-by: bdhivya <[email protected]>
Signed-off-by: bdhivya <[email protected]>
DhivyaBharathi215
requested review from
suhasbshekar and
wenjun666
as code owners
suhasbshekar
left a comment
suhasbshekar
left a comment
There was a problem hiding this comment.
looking good, please fix the lint issues
|
|
||
| // setAuthMethod determines the authentication method based on available credentials | ||
| func (c *HTTPClient) setAuthMethod() (AuthMethod, error) { | ||
| // Defaults to cert authentication if both basic and client certificate authentication parameters are given |
There was a problem hiding this comment.
@suhasbshekar Is it a good idea to allow user to input both basic and cert auth? Setting default seems not explicit enough.
There was a problem hiding this comment.
it is actually not Defaulted, we should change the wording in the comment, users are allowed to input both basic and cert auth, if they use it together, then cert auth is considered, @DhivyaBharathi215 you can change the wording to "cert auth is prioritized if f both basic and client certificate authentication parameters are given
There was a problem hiding this comment.
as of now, ansible is having the same logic as well, it seems right, let user be free to configure, if they provide both, lets have a priority of which needs to be considered
Signed-off-by: bdhivya <[email protected]>
|
Do we need the documentation regarding this? |
Added ssl certificate based authentication in addition to basic username and password authentication