-
Notifications
You must be signed in to change notification settings - Fork 14
Modernize project for compatibility with uv #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Modernize project for compatibility with uv #71
Conversation
9379efb to
7c485c4
Compare
96b4d9c to
bad4db7
Compare
0445ae8 to
3b3534a
Compare
|
@StephenOman we have failing tests where the virtual environment does not have the packages (pytest etc) to run tests. We can fix these failures by installing the missing packages in the relevant virtual environment but I'm a little unclear as to what the failing tests are intended to test. We already have tests passing which run tests from a developer-like virtual environment (set up with dev dependencies using uv). |
|
These tests are supposed to test the distributions (source distribution and ManyLinux wheel) that would be available from PyPI if released. |
f471d32 to
d4012b8
Compare
d4012b8 to
ad4ff03
Compare
heiner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! In a future change, it's probably possible to remove setup.py entirely by switching the build system to build-backend = "scikit_build_core.build", i.e. this. This would remove the custom build logic by adding a minor amount of indirection.
|
I've made significant progress with the sci-kit build setup already. I can set up a PR if you're able to offer input? |
|
In the interest of small PRs I'd suggest landing this one first, then doing sci-kit build in the next one? |
|
Totally agreed. This PR is big enough as is and I don't have the sci-kit build setup working perfectly yet. |
Lock build-deps as uv does not yet support locking of build deps: astral-sh/uv#5190
|
Quick question, is this change a breaking change? Can people still install and build without uv? Also, perhaps we should add uv instructions to the documentation. |
|
Any tool that is compatible with https://peps.python.org/pep-0621/ should be able to build and install the package; that includes |
Closes #70.