Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Scumblr docker configuration #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sbasgall
Copy link

@sbasgall sbasgall commented Nov 30, 2016

docker-compose for Scumblr issue #54

It mostly follows best practices although there are a few warts.
I made a few decisions with best judgement and open to any feedback.

Thanks for making Scumblr!

@sbasgall
Copy link
Author

sbasgall commented Dec 1, 2016

I removed the default credentials based on feedback the project provided to PR #99

@ahoernecke
Copy link
Contributor

Hi @sbasgall,

Thanks, this looks great! I'm going to test it out and assuming all goes well we will roll it into a separate repo and provide instructions for using it in the wiki.

Thank you again!

@sbasgall
Copy link
Author

sbasgall commented Dec 2, 2016

@ahoernecke Great news!

It should come up just fine. There are a couple improvements I'd like to make eventually but I wanted to share what is already done so it's easier for people to evaluate and launch this great service!

@sbasgall
Copy link
Author

sbasgall commented Dec 3, 2016

Hi @ahoernecke,

I'm not sure what the project's plans are to create a separate repo for the Docker image build files but having a repo in the style of the official docker image packaging might be nice.

Here is an official example for mysql:
https://github.com/docker-library/mysql

Here is a third party example for Vault:
https://github.com/hashicorp/docker-vault
https://github.com/docker-library/docs/tree/master/vault

Hashicorp has a model where commits trigger a new docker image build to upload to a public container registry after running some CI tests.

Following this pattern would mean things like docker-compose.yml and possibly scumblr-vars.envmight still technically belong in the main project repo.

If the goal is to keep the main project repository free of any docker related files using a layout similar to this still seems worth considering.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants