Fix: JobSet with @retry(times=0) validation error

[Dhanush010]

When using @Retry(times=0) with JobSet through Argo Workflows, the workflow fails because {{retries}} is added to the jobset-name even though retryStrategy is not specified in the template.

The issue was that the code checked for the presence of the @Retry decorator instead of checking if retries are actually enabled (total_retries > 0). When total_retries = 0, retry_strategy() doesn't add retryStrategy, so {{retries}} is not available in Argo Workflows.

Fix by computing total_retries and only adding retry-related parameters (including {{retries}} in the jobset-name) when total_retries > 0.

Fixes #2632

[Dhanush010]

Hi,
I've fixed the pre-commit formatting issue. The black formatter required the max() call to be split across multiple lines. Applied the formatting fix and pushed the changes - the pre-commit check should pass now.

[Dhanush010]

Hi @valayDave,
The test failure is due to a transient infrastructure issue, not related to the code changes. The error shows:
Error: failed to fetch https://github.com/argoproj/argo-helm/releases/download/argo-events-2.4.8/argo-events-2.4.8.tgz : 503 Service Unavailable

This occurred during the "Bring up the environment" step when trying to download the argo-events Helm chart. The failure happened before any actual tests ran. This is a GitHub release download service issue (503 error), not a problem with the code changes.

Could someone please re-run the test? The other 31 checks passed successfully.