Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the project from traditional setuptools with setup.py to modern Python packaging using uv as the primary package manager and build tool. The migration simplifies dependency management, build processes, and CI/CD workflows while maintaining backward compatibility.
Changes:
- Replaced
setup.pywithpyproject.tomlusinghatchlingas the build backend - Migrated all GitHub Actions workflows to use
uvfor dependency installation, testing, and publishing - Updated version management to use
uv versioncommand and dynamic version loading viaimportlib.metadata - Enhanced
algorithm_loader.pyto preferuv pipoverpipwhen available
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Removed legacy setuptools-based configuration file |
| pyproject.toml | Added modern PEP 621 compliant project configuration with uv-specific settings |
| neuracore/init.py | Updated to use dynamic version loading from package metadata |
| neuracore/ml/utils/algorithm_loader.py | Enhanced to prefer uv pip when available with graceful pip fallback |
| .bumpversion.cfg | Removed in favor of uv's built-in version management |
| .github/workflows/*.yaml | Updated all CI/CD workflows to use astral-sh/setup-uv@v5 and uv commands |
| README.md | Added uv installation instructions and updated development/testing commands |
| cSpell.json | Added pyproject.toml and uv.lock to ignore list |
| neuracore-dictionary.txt | Added "venv" to custom dictionary |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b71054f to
67a232f
Compare
380be02 to
8acf12b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
uvwhere-ever possible.Test Script