fix: fix p2p connection to use loop call soon threadsafe#407
Merged
mark-neuracore merged 1 commit intodevelopfrom Feb 19, 2026
Merged
Conversation
Contributor
|
✅ PR source branch is valid
|
24f9d1e to
c5b72a2
Compare
c5b72a2 to
850a986
Compare
Contributor
CougarTasker
left a comment
There was a problem hiding this comment.
Issue: This solution feels like we are just smothing over the issue. Mixing blocking and non-blocking code like this raises alarm-bells for me.
Suggestion: I suspect there is a more elegant approach to provide the event loop context to the required code.
Question: Does this issue apprear for other senesor types that are not parallel grippers, If not why?
cfd10cc to
13735c8
Compare
Contributor
Author
|
@CougarTasker found this way to avoid modifying aiortc. still happy to raise a pr with our previous solution to pass the self.loop in aiortc |
2de4733 to
506fc37
Compare
CougarTasker
approved these changes
Feb 19, 2026
| ) | ||
| future.result(timeout=5.0) | ||
|
|
||
| async def _add_event_source_impl(self, source: JSONSource) -> None: |
Contributor
There was a problem hiding this comment.
nit: These callback functions can look a little neater if inline
506fc37 to
7b027ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfixes
self.loopinstead.