Skip to content

feat: training only allow dataset name#412

Open
ypang-neuraco wants to merge 1 commit intodevelopfrom
feat/training-only-allow-dataset-name
Open

feat: training only allow dataset name#412
ypang-neuraco wants to merge 1 commit intodevelopfrom
feat/training-only-allow-dataset-name

Conversation

@ypang-neuraco
Copy link
Contributor

Features

  • Remove dataset ID as input from training runs

Expected behaviour

  • Dataset name unique within org
  • User's own dataset can share the same name with shared dataset
  • When selecting dataset for training, prioritise user's dataset in org over shared dataset. Fall back to shared dataset if no matching dataset found in org

Items

@ypang-neuraco ypang-neuraco self-assigned this Feb 17, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

PR source branch is valid

  • Source: feat/training-only-allow-dataset-name
  • Target: develop

@ypang-neuraco ypang-neuraco added the version:major any breaking change to behaviour, inputs or outputs label Feb 17, 2026
@github-actions
Copy link
Contributor

Consider updating changelogs/pending-changelog.md with a summary of this change for the release notes. This is optional and non-blocking.

@ypang-neuraco ypang-neuraco force-pushed the feat/training-only-allow-dataset-name branch from a55d2c8 to f1eaab9 Compare February 17, 2026 15:06
@ypang-neuraco ypang-neuraco force-pushed the feat/training-only-allow-dataset-name branch from f1eaab9 to eb71123 Compare February 17, 2026 16:16
@kwangneuraco
Copy link
Contributor

kwangneuraco commented Feb 18, 2026

Hi i just give a bit more context, there are several concerns regarding this change: (1) please make sure dataset name is uniquely linked to one dataset id, and after the change of the dataset name, it is still valid.
(2) Before we had a concern that dataset maybe shared between different organizations, and the dataset name may conflict with some private ones, how this can be handled?
Maybe we should talk with @CougarTasker before proceed with it :)

@ypang-neuraco
Copy link
Contributor Author

Hi i just give a bit more context, there are several concerns regarding this change: (1) please make sure dataset name is uniquely linked to one dataset id, and after the change of the dataset name, it is still valid. (2) Before we had a concern that dataset maybe shared between different organizations, and the dataset name may conflict with some private ones, how this can be handled? Maybe we should talk with @CougarTasker before proceed with it :)

(1) From what I understand, when creating datasets the name is checked against other dataset names within the organisation so the dataset name should be unique within the organisation. When selecting dataset by name, we only search within the organisation so one dataset name should only map to one dataset ID. Additionally, users are not allowed to rename a dataset to be the same name as another dataset within the organisation. I haven't checked what happens after renaming so I will try that and come back to you.

(2) I don't have the context on this but I think if datasets were to be shared between organisations, and there is a conflict in the name, at that point we can ask the user to rename the dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:major any breaking change to behaviour, inputs or outputs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments