-
Notifications
You must be signed in to change notification settings - Fork 260
Update for MaxWell systems #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Correct duplicate channel_id assignments within stream (keep first instance)
MaxWell sometimes creates non-bijective channel-electrode mapping. Warn users but allow to proceed as this will be dealt with in neobaseextractor in spikeinterface.
Hi. |
Using names should be OK, right? Then people can use the "use_names_as_ids" in SpikeInterface They names are also propagated as a property that can be used in SpikeInterface to fix things downstream. |
Yes, using names should be fine as these are propagated and can be subsequently dealt in SpikeInterface. A singular enforcement of uniqueness should be implemented here then (throw out any duplicated names after the first) as required. |
We discussed this in our meeting and we can't have this change in Neo-baserawio. We will need to fix this at the Maxwell level. Feel free to open an issue to discuss this more. |
MaxWell channel-electrode mappings may not be bijective (see #1703). Throw a warning rather than an error if this is the case and address this correctly downstream in spikeinterface modules.